Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced annotation support for SQL databases for name, type, indexes and generated fields #58

Merged
merged 20 commits into from
Feb 21, 2024

Conversation

hasathcharu
Copy link
Contributor

Purpose

Advanced annotation support for SQL databases for name mapping, type mapping, relation mapping, indexes and auto generated columns to support database introspection.
Fixes: ballerina-platform/ballerina-library/issues/6013

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@CLAassistant
Copy link

CLAassistant commented Feb 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (8907ed0) 83.35% compared to head (a780d13) 82.69%.

Files Patch % Lines
ballerina/annotations.bal 0.00% 11 Missing ⚠️
ballerina/sql_client.bal 81.81% 2 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             introspection-support      #58      +/-   ##
===========================================================
- Coverage                    83.35%   82.69%   -0.67%     
  Complexity                     169      169              
===========================================================
  Files                           22       23       +1     
  Lines                         1256     1271      +15     
  Branches                       359      363       +4     
===========================================================
+ Hits                          1047     1051       +4     
- Misses                         152      163      +11     
  Partials                        57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hasathcharu hasathcharu requested a review from daneshk February 20, 2024 08:19
@hasathcharu hasathcharu requested a review from daneshk February 20, 2024 11:40
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daneshk daneshk changed the base branch from main to introspection-support February 21, 2024 05:08
@daneshk daneshk merged commit bc4b026 into ballerina-platform:introspection-support Feb 21, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add annotation support for mapping between SQL Database implementation and Ballerina Entity model.
3 participants