Add static code rules to the MySQL module #1330
Conversation
SachinAkash01
requested review from
niveathika,
RDPerera and
shafreenAnfar
as code owners
.../test/java/io/ballerina/stdlib/mysql/compiler/staticcodeanalyzer/StaticCodeAnalyzerTest.java
Show resolved
Hide resolved
| import io.ballerina.scan.Rule; | ||
| import io.ballerina.scan.RuleKind; | ||
|
|
||
| public class RuleImpl implements Rule { |
There was a problem hiding this comment.
Let's add a doc comment for the class. Check for other similar cases
| ExpressionNode expression = namedArgument.expression(); | ||
| if (expression instanceof BasicLiteralNode basicLiteralNode) { | ||
| String passwordValue = basicLiteralNode.literalToken().text(); | ||
| passwordValue = passwordValue.substring(1, passwordValue.length() - 1); |
There was a problem hiding this comment.
Just trying to understand; why are we taking a substring here?
| hasSecurePassword = true; | ||
| } | ||
| } | ||
| else { |
There was a problem hiding this comment.
Why does this else block require an issue to be reported? Shall we add a small comment similar to what you have done in https://github.com/ballerina-platform/module-ballerinax-mysql/pull/1330/files#diff-6fae5cf6aa18601e6116b6f471bbadf8b93196443c0df31db5a6137060cd735eR65:~:text=//%20Check%20if-,the,-expression%20is%20a explaining the reason?
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (72.80%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1330 +/- ##
============================================
- Coverage 80.85% 72.80% -8.06%
+ Complexity 126 125 -1
============================================
Files 20 25 +5
Lines 564 625 +61
Branches 110 119 +9
============================================
- Hits 456 455 -1
- Misses 61 121 +60
- Partials 47 49 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Purpose
Related issues: #7511 #7283
Examples
Checklist