Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gyro ECLP validations #97

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Add gyro ECLP validations #97

merged 3 commits into from
Mar 5, 2025

Conversation

MattPereira
Copy link
Member

@MattPereira MattPereira commented Mar 4, 2025 •
edited
Loading

Plan is to use this for balancer/b-sdk#570

Summary

  • Tried to match syntax of SC implementation as close as possible
  • Tried to be helpful with error messages
    • For simple checks directly on param values, offer range values in error message
    • For validations that do math on params then check range, just use custom error name

@MattPereira MattPereira requested a review from johngrantuk March 5, 2025 00:01
@MattPereira MattPereira mentioned this pull request Mar 5, 2025
Open
johngrantuk
johngrantuk approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@johngrantuk johngrantuk merged commit 39f410a into main Mar 5, 2025
2 checks passed
@johngrantuk johngrantuk deleted the eclp-param-validations branch March 5, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngrantuk johngrantuk johngrantuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattPereira @johngrantuk