feat: create lbp #605
feat: create lbp #605
Conversation
There was a problem hiding this comment.
Overall approach to input validator seems to make sense - I don't think we can do much better than this with how it's currently structured - let's consider a greater refactor in another PR 👍
I left a few comments that should help polish the current implementation a bit.
src/entities/createPool/types.ts
Outdated
| export type CreatePoolInput = | ||
| | CreatePoolV2WeightedInput | ||
| | CreatePoolV2ComposableStableInput | ||
| | CreatePoolV3WeightedInput | ||
| | CreatePoolV3StableInput | ||
| | CreatePoolStableSurgeInput; | ||
| | CreatePoolStableSurgeInput | ||
| | CreateLiquidityBoostrappingPoolInput; |
There was a problem hiding this comment.
I'd keep the standard:
| | CreateLiquidityBoostrappingPoolInput; | |
| | CreatePoolLiquidityBootstrappingInput; |
| @@ -34,7 +37,9 @@ export class InputValidatorComposableStable extends InputValidatorBase { | |||
| } | |||
|
|
|||
| validateCreatePool(input: CreatePoolV2ComposableStableInput): void { | |||
| super.validateCreatePool(input); | |||
| validateCreatePoolTokens(input.tokens); | |||
| validateCreatePoolTokenConfig(input); | |||
There was a problem hiding this comment.
validateCreatePoolTokenConfig seems to be relevant to v3 only and ComposableStable exists only on V2 so you should be able to remove this from here
| | CreatePoolV2WeightedInput | ||
| | CreatePoolV2ComposableStableInput |
There was a problem hiding this comment.
We don't have Boosted pools on V2, so you should be able to remove these 2 options
| throw new Error('Start time must be in the future'); | ||
| } | ||
| // tokens cannot be the same | ||
| if (input.lbpParams.projectToken === input.lbpParams.reserveToken) { |
There was a problem hiding this comment.
Please use isSameAddress helper to avoid issues with case sensitive comparisons
| | CreatePoolV2WeightedInput | ||
| | CreatePoolV2ComposableStableInput |
There was a problem hiding this comment.
Same here about removing first 2 options (which are related to V2)
|
I'm having the same maybe something to do with that last PR bruno merged? 🤔 |
There was a problem hiding this comment.
Should be no change to the pnpm-lock file.
There was a problem hiding this comment.
@mkflow27 I ran into the same lockfileVerison: '9.0' change causing problem with Lint check
The cause was that my machine had pnpm v9.x globally installed
The fix was...
- global install of verison that matches our
package.json
npm install -g pnpm@8.6.0
- revert the lock file back to state of latest commit on main branch
git checkout de8956de -- pnpm-lock.yaml
- run install again
pnpm install
I believe its because the pnpm-lockfile is updated with a different version. Reverting that change should fix things. |
This feature add lbp creation support to the sdk.
Outstanding: