Add Dialect check for ALTER TABLE ENABLE/DISABLE TRIG ALL #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nirmit Shah <nirmisha@amazon.com>
1 task
tanscorpio7
reviewed
Mar 5, 2025
Comment on lines
+2824
to
+2831
| if(sql_dialect == SQL_DIALECT_TSQL) | ||
| { | ||
| n->subtype = AT_DisableTrigUser; | ||
| } | ||
| else | ||
| { | ||
| n->subtype = AT_DisableTrigAll; | ||
| } |
There was a problem hiding this comment.
re writing this in Antlr would be more preferable if possible.
There was a problem hiding this comment.
Nice catch, will close this , and rewrite in ANTLR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To Disable FKEY Action Triggers we need superuser privileges code reference , But for tsql we only need to disable user defined triggers , You can see the difference between ALL vs USER Enable/Disable here . We should specify the
AT_[Disable/Enable]TrigUsercommand forENABLE/DISABLE TRIGGER ALLSyntax instead ofAT_[Disable/Enable]TrigAllExtension PR babelfish-for-postgresql/babelfish_extensions#3547
Issues Resolved
BABEL-5645
Signed-off-by: Nirmit Shah nirmisha@amazon.com
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.