Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance testing coverage for Exact Numeric data types. #3497

Open
wants to merge 4 commits into
base: BABEL_5_X_DEV
Choose a base branch
from

Conversation

Yvinayak07
Copy link
Contributor

@Yvinayak07 Yvinayak07 commented Feb 17, 2025

Description

Working on enhancement of test coverage for exact numeric datatypes:

  1. tinyint,
  2. smallint,
  3. int,
  4. bigint.

Test Plan: https://quip-amazon.com/aL2xAKs3EHtl/Test-Plan-for-Exact-Numeric-DataTypes

Issues Resolved

BABEL-5621

Test Scenarios Covered

  • Use case based - YES

  • Boundary conditions - YES

  • Arbitrary inputs - YES

  • Negative test cases - YES

  • Minor version upgrade tests - NA

  • **Major version upgrade tests -**NA

  • Performance tests -

  • Tooling impact - NA

  • Client tests - NA

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

yashneet vinayak added 2 commits February 17, 2025 10:39
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
@coveralls
Copy link
Collaborator

coveralls commented Feb 17, 2025

Pull Request Test Coverage Report for Build 13387270067

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 395 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 75.031%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tsql/src/pl_funcs.c 2 19.04%
contrib/babelfishpg_tsql/src/pl_handler.c 133 90.09%
contrib/babelfishpg_tsql/src/pltsql_ruleutils.c 260 61.29%
Totals Coverage Status
Change from base Build 13365752176: 0.02%
Covered Lines: 47144
Relevant Lines: 62833

💛 - Coveralls

yashneet vinayak added 2 commits February 18, 2025 09:23
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants