Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance testing coverage for [var]binary data types #3459

Open
wants to merge 11 commits into
base: BABEL_5_X_DEV
Choose a base branch
from
Open

Enhance testing coverage for [var]binary data types #3459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ab982bc
Enhance testing coverage for [var]binary data types
Feb 5, 2025
8182a6f
Fixed Binary type expected file
Feb 5, 2025
8999f23
Fixed output file
Feb 7, 2025
72f869d
Fixed output file
Feb 7, 2025
a5fcef7
Merge branch 'babelfish-for-postgresql:BABEL_5_X_DEV' into binary-test
Deepesh125 Feb 10, 2025
30fb7ca
new test cases
Feb 19, 2025
30a5bdd
Final set of test cases
Feb 21, 2025
b1f9e96
system tests
Feb 21, 2025
fc29216
some more test cases
Feb 21, 2025
095cea3
Merge branch 'babelfish-for-postgresql:BABEL_5_X_DEV' into binary-test
Deepesh125 Feb 25, 2025
1075a3b
Merge branch 'babelfish-for-postgresql:BABEL_5_X_DEV' into binary-test
Deepesh125 Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions test/JDBC/expected/BasicTestBinary.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
CREATE TABLE BINARY_dt(a BINARY(5), b VARBINARY(10));
#inserting random values
INSERT INTO BINARY_dt(a, b) values (1234, 12345);
~~ROW COUNT: 1~~

INSERT INTO BINARY_dt(a, b) values (NULL, NULL);
~~ROW COUNT: 1~~

INSERT INTO BINARY_dt(a, b) values (0x31323334, 0x3132333435);
~~ROW COUNT: 1~~

INSERT INTO BINARY_dt(a, b) values (0x31323334, 0x00);
~~ROW COUNT: 1~~

INSERT INTO BINARY_dt(a, b) values (0x00, 0x3132333435);
~~ROW COUNT: 1~~

INSERT INTO BINARY_dt(a, b) values (0x31323334, 0x);
~~ROW COUNT: 1~~

INSERT INTO BINARY_dt(a, b) values (0x, 0x3132333435);
~~ROW COUNT: 1~~


#boundary conditions
INSERT INTO BINARY_dt(a, b) values (0x3132333435, 0x31323334353637383940);
~~ROW COUNT: 1~~

INSERT INTO BINARY_dt(a, b) values (0x313233343536, 0x31323334353637383940);
~~ERROR (Code: 33557097)~~

~~ERROR (Message: String or binary data would be truncated.
The statement has been terminated.)~~

INSERT INTO BINARY_dt(a, b) values (0x3132333435, 0x3132333435363738394041);
~~ERROR (Code: 33557097)~~

~~ERROR (Message: String or binary data would be truncated.
The statement has been terminated.)~~


#string to binary insert / test left padding
INSERT INTO BINARY_dt(a, b) values ('abc ', ' abc ');
~~ERROR (Code: 33557097)~~

~~ERROR (Message: cannot coerce string literal to binary datatype)~~


SELECT * FROM BINARY_dt order by a;
~~START~~
binary#!#varbinary
<NULL>#!#<NULL>
0000000000#!#3132333435
0000000000#!#3132333435
00000004D2#!#00003039
3132333400#!#00
3132333400#!#
3132333400#!#3132333435
3132333435#!#31323334353637383940
~~END~~


prepst#!# INSERT INTO BINARY_dt(a, b) values(?, ?) #!#binary|-|a|-|1234#!#varbinary|-|b|-|12345
~~ROW COUNT: 1~~

prepst#!#exec#!#binary|-|a|-|12345678#!#varbinary|-|b|-|12345
~~ERROR (Code: 33557097)~~

~~ERROR (Message: String or binary data would be truncated.
The statement has been terminated.)~~

prepst#!#exec#!#binary|-|a|-|12345#!#varbinary|-|b|-|12345678999
~~ERROR (Code: 33557097)~~

~~ERROR (Message: String or binary data would be truncated.
The statement has been terminated.)~~

prepst#!#exec#!#binary|-|a|-|<NULL>#!#varbinary|-|b|-|<NULL>
~~ROW COUNT: 1~~


SELECT * FROM BINARY_dt order by a;
~~START~~
binary#!#varbinary
<NULL>#!#<NULL>
<NULL>#!#<NULL>
0000000000#!#3132333435
0000000000#!#3132333435
00000004D2#!#00003039
3132333400#!#
3132333400#!#00
3132333400#!#3132333435
3132333400#!#3132333435
3132333435#!#31323334353637383940
~~END~~

DROP TABLE BINARY_dt;

3,163 changes: 3,136 additions & 27 deletions test/JDBC/expected/TestBinary.out
View file
Open in desktop

Large diffs are not rendered by default.

28 changes: 28 additions & 0 deletions test/JDBC/input/datatypes/BasicTestBinary.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
CREATE TABLE BINARY_dt(a BINARY(5), b VARBINARY(10));
#inserting random values
INSERT INTO BINARY_dt(a, b) values (1234, 12345);
INSERT INTO BINARY_dt(a, b) values (NULL, NULL);
INSERT INTO BINARY_dt(a, b) values (0x31323334, 0x3132333435);
INSERT INTO BINARY_dt(a, b) values (0x31323334, 0x00);
INSERT INTO BINARY_dt(a, b) values (0x00, 0x3132333435);
INSERT INTO BINARY_dt(a, b) values (0x31323334, 0x);
INSERT INTO BINARY_dt(a, b) values (0x, 0x3132333435);

#boundary conditions
INSERT INTO BINARY_dt(a, b) values (0x3132333435, 0x31323334353637383940);
INSERT INTO BINARY_dt(a, b) values (0x313233343536, 0x31323334353637383940);
INSERT INTO BINARY_dt(a, b) values (0x3132333435, 0x3132333435363738394041);

#string to binary insert / test left padding
INSERT INTO BINARY_dt(a, b) values ('abc ', ' abc ');

SELECT * FROM BINARY_dt order by a;

prepst#!# INSERT INTO BINARY_dt(a, b) values(@a, @b) #!#binary|-|a|-|1234#!#varbinary|-|b|-|12345
prepst#!#exec#!#binary|-|a|-|12345678#!#varbinary|-|b|-|12345
prepst#!#exec#!#binary|-|a|-|12345#!#varbinary|-|b|-|12345678999
prepst#!#exec#!#binary|-|a|-|<NULL>#!#varbinary|-|b|-|<NULL>

SELECT * FROM BINARY_dt order by a;
DROP TABLE BINARY_dt;

Loading
Loading