adddressing comments

Signed-off-by: yashneet vinayak <yashneet@amazon.com>

contrib/babelfishpg_common/sql/upgrades/babelfish_common_helper--3.8.0--3.9.0.sql

@@ -8,11 +8,11 @@
 SELECT set_config('search_path', 'sys, '|| current_setting('search_path'), false);
 
 CREATE OR REPLACE FUNCTION sys.varbinary2datetime(sys.BBF_VARBINARY)
-RETURNS DATETIME
+RETURNS sys.DATETIME
 AS 'babelfishpg_common', 'varbinary_datetime'
 LANGUAGE C IMMUTABLE STRICT PARALLEL SAFE;
 
-CREATE CAST (sys.BBF_VARBINARY AS DATETIME)
+CREATE CAST (sys.BBF_VARBINARY AS sys.DATETIME)
 WITH FUNCTION sys.varbinary2datetime(sys.BBF_VARBINARY) AS IMPLICIT;
 
 -- Reset search_path to not affect any subsequent scripts

test/JDBC/expected/babel_datetime-vu-cleanup.out

@@ -9,3 +9,5 @@ drop view babel_datetime_vu_view2
 go
 drop procedure babel_datetime_vu_procedure
 go
+drop function babel_datetime_vu_function1
+go

test/JDBC/expected/babel_datetime-vu-prepare.out

@@ -92,3 +92,11 @@ BEGIN
 	select cast(0x00008EE700C5C100 as datetime)
 END;
 GO
+
+CREATE FUNCTION babel_datetime_vu_function1 (@inputdate DATETIME)
+RETURNS varchar(50)
+AS
+BEGIN
+	RETURN @inputdate
+END
+GO

test/JDBC/expected/babel_datetime-vu-verify.out

@@ -888,3 +888,11 @@ datetime
 2000-02-29 12:00:00.0
 ~~END~~
 
+
+SELECT babel_datetime_vu_function1(0x0000B02200EF28C1)
+GO
+~~START~~
+varchar
+2023-06-15 14:30:45.123
+~~END~~
+

test/JDBC/input/babel_datetime-vu-cleanup.sql

@@ -9,3 +9,5 @@ drop view babel_datetime_vu_view2
 go
 drop procedure babel_datetime_vu_procedure
 go
+drop function babel_datetime_vu_function1
+go

test/JDBC/input/babel_datetime-vu-prepare.sql

@@ -55,4 +55,12 @@ AS
 BEGIN
 	select cast(0x00008EE700C5C100 as datetime)
 END;
-GO
+GO
+
+CREATE FUNCTION babel_datetime_vu_function1 (@inputdate DATETIME)
+RETURNS varchar(50)
+AS
+BEGIN
+	RETURN @inputdate
+END
+GO

test/JDBC/input/babel_datetime-vu-verify.sql

@@ -340,3 +340,6 @@ GO
 
 EXEC babel_datetime_vu_procedure
 GO
+
+SELECT babel_datetime_vu_function1(0x0000B02200EF28C1)
+GO