Status condition from unstructured object #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellistarn
reviewed
May 20, 2024
jigisha620
force-pushed
the
feat-status-unstructured
branch
from
722907e to
9867547
Compare
jigisha620
force-pushed
the
feat-status-unstructured
branch
from
9867547 to
6ec7ba8
Compare
jigisha620
changed the title
jigisha620
force-pushed
the
feat-status-unstructured
branch
from
6ec7ba8 to
e1eb8e6
Compare
jigisha620
force-pushed
the
feat-status-unstructured
branch
2 times, most recently
from
e1c5851 to
60fdd0d
Compare
jigisha620
force-pushed
the
feat-status-unstructured
branch
from
60fdd0d to
a7c2590
Compare
ellistarn
previously approved these changes
Jun 15, 2024
jonathan-innis
previously approved these changes
Jun 15, 2024
jigisha620
dismissed stale reviews from jonathan-innis and ellistarn
via
d60c9c2
jigisha620
force-pushed
the
feat-status-unstructured
branch
from
a7c2590 to
d60c9c2
Compare
ellistarn
previously approved these changes
Jun 15, 2024
jonathan-innis
previously approved these changes
Jun 16, 2024
jigisha620
dismissed stale reviews from jonathan-innis and ellistarn
via
4398356
jigisha620
force-pushed
the
feat-status-unstructured
branch
from
d60c9c2 to
4398356
Compare
|
Closing this out since we went a different direction. We'll re-open this if we think that this is needed later down the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds a change to convert unstructured object into a known type so that we can we can reuse the standard condition handling methods. Making this change in response to - kubernetes-sigs/karpenter#1248 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.