Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Emit events when finalizers complete #103

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ellistarn
Copy link
Contributor

Issue #, if available:

Description of changes:
Track and emit events for finalizers. This is identical to how events are emitted for condition transitions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ellistarn ellistarn requested a review from a team as a code owner November 19, 2024 22:55
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn merged commit 3a30256 into awslabs:main Nov 19, 2024
1 check passed
@ellistarn ellistarn deleted the finalizer branch November 21, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants