feat(dns): initial support dns module #825
Open
+364
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should reuse the DNS resolver we added for llrt_http. Probably need to split a lib crate. |
nabetti1720
force-pushed
the
feat/support-dns-module
branch
from
00e4b78 to
c908668
Compare
richarddavison
requested changes
Feb 18, 2025
@richarddavison , Thank you for your comment. Please be patient and wait for me. :) |
nabetti1720
force-pushed
the
feat/support-dns-module
branch
from
c756460 to
159b58c
Compare
richarddavison
requested changes
Feb 24, 2025
Sorry if I overlooked your suggestion. Is there still something to improve? |
richarddavison
requested changes
Feb 24, 2025
Comment on lines
+3
to
+27
| describe("lookup", () => { | ||
| it("optionless", (done) => { | ||
| dns.lookup("localhost", (err, address, family) => { | ||
| expect(address === "::1" || address === "127.0.0.1").toBeTruthy(); | ||
| expect(family === 4 || family === 6).toBeTruthy(); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it("option - integer", (done) => { | ||
| dns.lookup("localhost", 4, (err, address, family) => { | ||
| expect(address).toEqual("127.0.0.1"); | ||
| expect(family).toEqual(4); | ||
| done(); | ||
| }); | ||
| }); | ||
|
|
||
| it("option - record", (done) => { | ||
| dns.lookup("localhost", { family: 4 }, (err, address, family) => { | ||
| expect(address).toEqual("127.0.0.1"); | ||
| expect(family).toEqual(4); | ||
| done(); | ||
| }); | ||
| }); | ||
| }); |
My misstake. For some reason the requested change was not published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
closed #827
Description of changes
This PR is an initial implementation of a Node.js compatible
dnsmodule. However, like other modules, we do not aim to implement all functions.dns.lookup(), has not been implemented.familyof numeric or record types is valid.Checklist
tests/unitand/or in Rust for my feature if neededmake fixto format JS and apply Clippy auto fixesmake checktypes/directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.