fix: Add type annotation to LambdaRequest's Deserialize impl to avoid compiler recursive loop #960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where the compiler would get into an infinite loop evaluating
lambda_http/src/deserializer.rs:23
. I haven't seen anyone else complaining, so this might just be an issue from my own code.I am not experienced in rust, or oss contributions in general, so apologies in advance if I am not following proper oss ettiquet and any advice/help would be appreciated.
📬 Issue #, if available:
n/a.
✍️ Description of changes:
added a type hint to deserialize implementation of LambdaRequest. This avoids an infinite loop when evaluating a Box::deserialize()
🔏 By submitting this pull request
cargo +nightly fmt
.cargo clippy --fix
.