refactor(s2n-quic-dc): rename source_stream_port to source_queue_id #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/dc-source-queue-id
branch
from
107e623 to
d7cedc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change renames the
source_stream_porttosource_queue_id. This change is required to communicate the sender's queue_id, which is then included in any responses from the receiver.Call-outs:
Note that this does change the wire format, but only for UDP streams, which are unstable currently. The TCP-based streams do not use
source_stream_portat all.The other thing to note is that split-socket streams are also broken by this change. This only applies to non-linux environments, which don't have reuse-port BPF routing capabilities. Once the recv socket pools are wired up, that will be the only supported mode of operation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.