Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s2n-quic-transport): allow migrations even when disable_active_migration is sent #2516

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

WesleyRosenblum
Copy link
Contributor

Release Summary:

Connection migrations are now allowed even when the disable_active_migration is set to true, as it is not possible to distinguish between the peer performing an active migration, and a NAT rebind.

Description of changes:

This change loosens two restrictions on connection migration:

  1. Migrations are now allowed even if the disable_active_migration transport parameter is set to true
  2. Migrations are allowed even if the peer did not supply sufficient connection IDs to allow for using a new connection ID on the new path

The reasoning for allowing migrations in these cases is that there is no way a server can definitely determine that a migration from the peer was intentional/active versus just a NAT rebind. The peer is allowed to change destination connection IDs at any time, so if a peer undergoes a NAT rebind at the same time they change destination CID, that would appear identical to an active migration. To increase availability, we will allow such cases to proceed with migration.

Testing:

Updated existing unit test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@WesleyRosenblum WesleyRosenblum changed the title fix(s2n-quic-transport): allow migrations even when disable_active_migrations is sent fix(s2n-quic-transport): allow migrations even when disable_active_migration is sent Mar 6, 2025
@WesleyRosenblum WesleyRosenblum merged commit c82daf7 into main Mar 6, 2025
129 checks passed
@WesleyRosenblum WesleyRosenblum deleted the WesleyRosenblum/allowmigration branch March 6, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants