Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s2n-quic-dc): Support storing ApplicationData in Entry #2515

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

Mark-Simulacrum
Copy link
Collaborator

@Mark-Simulacrum Mark-Simulacrum commented Mar 6, 2025

Release Summary:

  • feat(dc): Support storing arbitrary application-provided data in Entry

Resolved issues:

n/a

Description of changes:

This stores arbitrary metadata (Arc) in each Entry. By default, we share a single Arc<()> across all entries, but applications can register a callback to produce different dat per path secret.

Call-outs:

None.

Testing:

No tests added, but the functionality is pretty obvious.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Mark-Simulacrum Mark-Simulacrum force-pushed the auth-context-storage branch 6 times, most recently from b4cd37f to b167c0e Compare March 6, 2025 15:54
@Mark-Simulacrum Mark-Simulacrum requested a review from camshaft March 6, 2025 16:28
camshaft
camshaft previously approved these changes Mar 6, 2025
Copy link
Contributor

@camshaft camshaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, though I think I agree with your thoughts around naming: ApplicationData seems more appropriate, yeah? I guess up to you on renaming it or proceeding with AuthContext.

@Mark-Simulacrum Mark-Simulacrum changed the title feat(s2n-quic-dc): Support storing an AuthContext in Entry feat(s2n-quic-dc): Support storing ApplicationData in Entry Mar 7, 2025
This stores arbitrary metadata (Arc<dyn Any>) in each Entry. By default,
we share a single `Arc<()>` across all entries, but applications can
register a callback to produce arbitrary other values.
@camshaft camshaft merged commit 8670e83 into aws:main Mar 7, 2025
119 checks passed
@Mark-Simulacrum Mark-Simulacrum deleted the auth-context-storage branch March 7, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants