Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin litemap and zerofrom versions to support current MSRV #2488

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Feb 26, 2025

Release Summary:

Resolved issues:

Description of changes:

Pin litemap and zerofrom versions to prior versions which support our current MSRV rust v1.74.1.

These two dependencies are from the url dep in s2n-quic-qns crate:

𝄞 cargo tree --invert zerofrom
zerofrom v0.1.6
├── icu_collections v1.5.0
│   ├── icu_normalizer v1.5.0
│   │   └── idna_adapter v1.2.0
│   │       └── idna v1.0.3
│   │           └── url v2.5.4
│   │               └── s2n-quic-qns v0.1.0 (/home/cameron/Projects/aws/s2n-quic/quic/s2n-quic-qns)
│   └── icu_properties v1.5.1
│       ├── icu_normalizer v1.5.0 (*)
│       └── idna_adapter v1.2.0 (*)
├── icu_provider v1.5.0
│   ├── icu_locid_transform v1.5.0
│   │   └── icu_properties v1.5.1 (*)
│   ├── icu_normalizer v1.5.0 (*)
│   └── icu_properties v1.5.1 (*)
├── yoke v0.7.5
│   ├── icu_collections v1.5.0 (*)
│   ├── icu_provider v1.5.0 (*)
│   └── zerovec v0.10.4
│       ├── icu_collections v1.5.0 (*)
│       ├── icu_locid v1.5.0
│       │   ├── icu_locid_transform v1.5.0 (*)
│       │   └── icu_provider v1.5.0 (*)
│       ├── icu_locid_transform v1.5.0 (*)
│       ├── icu_normalizer v1.5.0 (*)
│       ├── icu_properties v1.5.1 (*)
│       ├── icu_provider v1.5.0 (*)
│       └── tinystr v0.7.6
│           ├── icu_locid v1.5.0 (*)
│           ├── icu_locid_transform v1.5.0 (*)
│           ├── icu_properties v1.5.1 (*)
│           └── icu_provider v1.5.0 (*)
└── zerovec v0.10.4 (*)
𝄞 cargo tree --invert litemap 
litemap v0.7.5
└── icu_locid v1.5.0
    ├── icu_locid_transform v1.5.0
    │   └── icu_properties v1.5.1
    │       ├── icu_normalizer v1.5.0
    │       │   └── idna_adapter v1.2.0
    │       │       └── idna v1.0.3
    │       │           └── url v2.5.4
    │       │               └── s2n-quic-qns v0.1.0 (/home/cameron/Projects/aws/s2n-quic/quic/s2n-quic-qns)
    │       └── idna_adapter v1.2.0 (*)
    └── icu_provider v1.5.0
        ├── icu_locid_transform v1.5.0 (*)
        ├── icu_normalizer v1.5.0 (*)
        └── icu_properties v1.5.1 (*)

Those two dependencies did a release today which bumped their MSRV to rust v1.81. That change breaks our CI, which is noticed in camshaft/bolero#270.

Hence, I am pining the prior versions of those two dependencies, so the integration tests with S2N-QUIC won't fail.

Call-outs:

I have pined those two versions to litemapv0.7.4 and zerofromv0.1.5. If our MSRV got updated to 1.81 or higher, then we can remove those pins.

Tracking this in Issue#2334.

Testing:

CI will test this PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boquan-fang boquan-fang force-pushed the zerofrom-dep-fix branch 2 times, most recently from c093b09 to d1d532a Compare February 26, 2025 22:55
@boquan-fang boquan-fang marked this pull request as ready for review February 26, 2025 23:08
@boquan-fang boquan-fang requested a review from camshaft February 26, 2025 23:08
@boquan-fang boquan-fang enabled auto-merge (squash) February 26, 2025 23:22
@camshaft camshaft disabled auto-merge February 26, 2025 23:43
@camshaft camshaft merged commit 65d6b6e into aws:main Feb 26, 2025
120 of 121 checks passed
dougch pushed a commit that referenced this pull request Mar 3, 2025
Co-authored-by: Boquan Fang <bqfang@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants