Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update qns actions for OIDC #2352

Merged
merged 5 commits into from
Oct 17, 2024
+40 −22
Merged

chore: update qns actions for OIDC #2352

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82fa1a7
chore: update qns actions for OIDC
dougch Oct 17, 2024
86f5849
ECR region change
dougch Oct 17, 2024
a63ba04
final qns credentials needing OIDC
dougch Oct 17, 2024
e711a54
update qns release workflow with OIDC changes
dougch Oct 17, 2024
8fa9c91
Fix the session names
dougch Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Fix the session names
@dougch
dougch committed Oct 17, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
commit 8fa9c91d704442976b36850df674b9610763eedc
10 changes: 5 additions & 5 deletions .github/workflows/qns.yml
View file
Original file line number Diff line number Diff line change
@@ -217,7 +217,7 @@ jobs:
if: github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name
with:
role-to-assume: arn:aws:iam::024603541914:role/GitHubOIDCRole
role-session-name: S2ntlsGHAS3Session
role-session-name: S2nQuicGHAS3Session
aws-region: us-west-2

- name: Upload to S3
@@ -309,7 +309,7 @@ jobs:
if: github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name
with:
role-to-assume: arn:aws:iam::024603541914:role/GitHubOIDCRole
role-session-name: S2ntlsGHAS3Session
role-session-name: S2nQuicGHAS3Session
aws-region: us-west-2

- name: Upload to S3
@@ -368,7 +368,7 @@ jobs:
if: github.repository == github.event.pull_request.head.repo.full_name
with:
role-to-assume: arn:aws:iam::024603541914:role/GitHubOIDCEcrRole
role-session-name: S2ntlsGHAECRSession
role-session-name: S2nQuicGHAECRSession
aws-region: us-east-1 # Required for ECR

# authenticate pull to avoid hitting pull quota
@@ -418,7 +418,7 @@ jobs:
if: github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name
with:
role-to-assume: arn:aws:iam::024603541914:role/GitHubOIDCRole
role-session-name: S2ntlsGHAS3Session
role-session-name: S2nQuicGHAS3Session
aws-region: us-west-2

- name: Upload results
@@ -566,7 +566,7 @@ jobs:
if: github.event_name == 'push' || github.repository == github.event.pull_request.head.repo.full_name
with:
role-to-assume: arn:aws:iam::024603541914:role/GitHubOIDCRole
role-session-name: S2ntlsGHAS3Session
role-session-name: S2nQuicGHAS3Session
aws-region: us-west-2

- name: Upload results
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Original file line number Diff line number Diff line change
@@ -48,7 +48,7 @@ jobs:
- uses: aws-actions/configure-aws-credentials@v4.0.2
with:
role-to-assume: arn:aws:iam::024603541914:role/GitHubOIDCEcrRole
role-session-name: S2ntlsGHAECRSession
role-session-name: S2nQuicGHAECRSession
aws-region: us-east-1 # Required for ECR

- name: Login to Amazon ECR Public

Unchanged files with check annotations Beta

View file
quic/s2n-quic-qns/etc/Dockerfile
rm -rf /var/cache/yum; \
curl https://sh.rustup.rs -sSf | bash -s -- -y;
WORKDIR app

Check warning on line 13 in quic/s2n-quic-qns/etc/Dockerfile

GitHub Actions / qns

Relative workdir without an absolute workdir declared within the build can have unexpected results if the base image changes 

WorkdirRelativePath: Relative workdir "app" can have unexpected results if the base image changes
More info: https://docs.docker.com/go/dockerfile/rule/workdir-relative-path/
RUN set -eux; \
source /root/.cargo/env; \