test(s2n-quic-platform): drain tx packets before closing host #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/testing-io-tx-drain
branch
from
495b2c1 to
c62e439
Compare
camshaft
force-pushed
the
camshaft/testing-io-tx-drain
branch
from
c62e439 to
14e7156
Compare
camshaft
force-pushed
the
camshaft/testing-io-tx-drain
branch
from
14e7156 to
29e8b5f
Compare
| @@ -23,6 +23,11 @@ pub use time::now; | |||
|
|
|||
| pub use bach::task::{self, primary, spawn}; | |||
|
|
|||
| // returns `true` if the caller is being executed in a testing environment | |||
| pub fn is_in_env() -> bool { | |||
There was a problem hiding this comment.
not sure I understand the name, why not something like is_testing_env?
There was a problem hiding this comment.
i was thinking testing was already in the module path name (io::testing::is_in_env()) so it seemed a bit redundant. But I don't have any strong opinions on the name.
There was a problem hiding this comment.
ah, yeah thats fine then
WesleyRosenblum
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The testing environment currently closes a socket on drop. This means that any outstanding packets in the TX queue are not submitted.
This change fixes that by marking the socket as closed and draining it. Once empty, the socket queue is removed from the network.
Call-outs:
I've also added a small function to know if the caller is running inside of a test environment or not.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.