Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding no-op X509_TRUST_cleanup for select application compatibility #2257

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

kingstjo
Copy link
Contributor

@kingstjo kingstjo commented Mar 7, 2025

Description of changes:

  • Re-implements X509_TRUST_cleanup() as a No-Op function after previous removal
  • Function was removed in commit #74c1f2a but is needed for select consuming applications
  • Added documentation explaining AWS-LC's different approach to trust settings

Testing:

  • No regression testing needed (No-Op implementation)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@kingstjo kingstjo requested a review from a team as a code owner March 7, 2025 02:20
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (5054cf0) to head (809580f).

Files with missing lines Patch % Lines
crypto/x509/x509_trs.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
- Coverage   79.05%   79.04%   -0.01%     
==========================================
  Files         612      612              
  Lines      106517   106519       +2     
  Branches    15052    15053       +1     
==========================================
- Hits        84204    84196       -8     
- Misses      21660    21670      +10     
  Partials      653      653              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

justsmth
justsmth previously approved these changes Mar 7, 2025
@andrewhop andrewhop merged commit cd3b9cd into aws:main Mar 7, 2025
103 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants