Cherry-pick to fips-2024-09-27 #2254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description of changes: Improve compatibility with OpenSSL APIs for OCSP. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit b74d80d)
### Description of changes: Can't track it down the historical reason why, but we have `BIO_get_mem_data` defined as a preprocessor macro, but BoringSSL does not. This creates an annoying compatibility issue for rust-openssl, and has forced us to implement the function properly in our aws-lc-sys crates in Rust. This redefines the function to have a concrete definition. As a side-note, the macro was technically wrong as it was casting contents to a `char *` when it was actually `char **`, but this wasn't problematic per-se since it was being passed into a `void *` argument. If you look at the ctrl function definition you can see that it is indeed treated as a `char **` pointer. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 5826a07)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fips-2024-09-27 #2254 +/- ##
===================================================
- Coverage 78.60% 78.59% -0.01%
===================================================
Files 585 585
Lines 100525 100527 +2
Branches 14250 14251 +1
===================================================
- Hits 79014 79007 -7
- Misses 20874 20885 +11
+ Partials 637 635 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This code does not modify the FIPS boundary.
Cherry-picks:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.