Remove unused CMake options for break tests #2249
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Setting the CMake option FIPS_BREAK_TEST to something like FFC_DH would result in defining
BORINGSSL_FIPS_BREAK_FFC_DH=1
which used to be how the break tests were broken. break-kat.go replaced all of that and all the code using the definitions were removed. 913af96 removed the last legacy usage of it.The correct way to test breaking AWS-LC is outlined in FIPS.md:
BORINGSSL_FIPS_BREAK_TESTS
definedThis also removes the note about fips_break_tests.h since that file doesn't exist anymore.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.