Make BIO_get_mem_data a function again #2246
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
==========================================
- Coverage 79.06% 79.05% -0.02%
==========================================
Files 612 612
Lines 106513 106515 +2
Branches 15052 15053 +1
==========================================
- Hits 84216 84204 -12
- Misses 21645 21659 +14
Partials 652 652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
Mar 6, 2025
samuel40791765
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Original Context: I was forced to change this to a macro because mySQL was using the function improperly. I submitted a change to upstream mysql to fix this. They've accepted it and it's in versions after mysql-8.3.0: https://bugs.mysql.com/bug.php?id=112846
We've agreed to use the referenced commit as a patch for any possible consumers of MySQL versions earlier than 8.3.
Merged
skmcgrail
added a commit
that referenced
this pull request
Mar 6, 2025
## What's Changed * Move OCSP ASN1 type functions to public header by @skmcgrail in #2239 * Make BIO_get_mem_data a function again by @skmcgrail in #2246 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
skmcgrail
added a commit
to skmcgrail/aws-lc
that referenced
this pull request
Mar 6, 2025
### Description of changes: Can't track it down the historical reason why, but we have `BIO_get_mem_data` defined as a preprocessor macro, but BoringSSL does not. This creates an annoying compatibility issue for rust-openssl, and has forced us to implement the function properly in our aws-lc-sys crates in Rust. This redefines the function to have a concrete definition. As a side-note, the macro was technically wrong as it was casting contents to a `char *` when it was actually `char **`, but this wasn't problematic per-se since it was being passed into a `void *` argument. If you look at the ctrl function definition you can see that it is indeed treated as a `char **` pointer. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 5826a07)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Can't track it down the historical reason why, but we have
BIO_get_mem_datadefined as a preprocessor macro, but BoringSSL does not. This creates an annoying compatibility issue for rust-openssl, and has forced us to implement the function properly in our aws-lc-sys crates in Rust. This redefines the function to have a concrete definition.As a side-note, the macro was technically wrong as it was casting contents to a
char *when it was actuallychar **, but this wasn't problematic per-se since it was being passed into avoid *argument. If you look at the ctrl function definition you can see that it is indeed treated as achar **pointer.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.