Enforce FIPS callback is only enabled for static builds #2241
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
=======================================
Coverage 79.04% 79.05%
=======================================
Files 612 612
Lines 106513 106513
Branches 15053 15054 +1
=======================================
+ Hits 84197 84201 +4
+ Misses 21664 21659 -5
- Partials 652 653 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewhop
force-pushed
the
fips_callback_shared
branch
from
412b6ae to
3399819
Compare
andrewhop
force-pushed
the
fips_callback_shared
branch
from
b51b6fb to
7eac873
Compare
skmcgrail
approved these changes
Mar 5, 2025
torben-hansen
approved these changes
Mar 5, 2025
justsmth
pushed a commit
that referenced
this pull request
Mar 6, 2025
### Description of changes: https://github.com/aws/aws-lc/releases/edit/untagged-aef9ee5aee62c3242f30 ## What's Changed * Remove BORINGSSL_FIPS_BREAK_FFC_DH by @andrewhop in #2216 * Increase required CMake version to 3.5 by @andrewhop in #2219 * Coverity Fix by @smittals2 in #2236 * Check pagesize is non-negative in AES-XTS test by @nebeid in #2237 * Don't 'dllexport' Windows symbols on static build by @justsmth in #2238 * Update to using Clang 18 on Windows by @justsmth in #2240 * Enforce FIPS callback is only enabled for static builds by @andrewhop in #2241 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Due to how shared libraries and applications load it's not possible for an application to dynamically link with AWS-LC and define it's own custom callback before AWS-LC's constructor runs which expects the callback to be defined. This change requires anyone expecting to build with the callback to statically build and link AWS-LC so their callback is defined before AWS-LC's constructor runs.
This change also enables the call_back_test to run all the time, this test can run on any platform, platforms that don't support the callback will get the default (abort) behavior.
This change also disables one death test if the callback is defined. Because the callback doesn't call abort the test fails.
Testing:
Update a test dimension to enable the callback and just run the tests like normal to ensure everything passes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.