Check pagesize is non-negative in AES-XTS test #2237
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smittals2
approved these changes
Mar 4, 2025
justsmth
approved these changes
Mar 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
- Coverage 79.04% 79.04% -0.01%
==========================================
Files 612 612
Lines 106510 106510
Branches 15053 15053
==========================================
- Hits 84192 84189 -3
- Misses 21664 21667 +3
Partials 654 654 ☔ View full report in Codecov by Sentry. |
justsmth
pushed a commit
that referenced
this pull request
Mar 6, 2025
### Description of changes: https://github.com/aws/aws-lc/releases/edit/untagged-aef9ee5aee62c3242f30 ## What's Changed * Remove BORINGSSL_FIPS_BREAK_FFC_DH by @andrewhop in #2216 * Increase required CMake version to 3.5 by @andrewhop in #2219 * Coverity Fix by @smittals2 in #2236 * Check pagesize is non-negative in AES-XTS test by @nebeid in #2237 * Don't 'dllexport' Windows symbols on static build by @justsmth in #2238 * Update to using Clang 18 on Windows by @justsmth in #2240 * Enforce FIPS callback is only enabled for static builds by @andrewhop in #2241 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #P206132928
Description of changes:
Coverity signaled that pagesize is passed to
mprotect()without ensuring it's non-negative.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.