Apply additional X509 validation checks on certificates sourced from trust store #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## x509 #2230 +/- ##
==========================================
- Coverage 79.05% 79.05% -0.01%
==========================================
Files 612 612
Lines 106476 106515 +39
Branches 15051 15053 +2
==========================================
+ Hits 84177 84207 +30
- Misses 21646 21655 +9
Partials 653 653 ☔ View full report in Codecov by Sentry. |
skmcgrail
force-pushed
the
rfc5280-4.2.1.9
branch
from
3642a97 to
97d12a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Improves validation of certificates by also applying additional checks for certificates retrieved from the trust store. This aligns AWS-LC with OpenSSL 1.1.1 and later behavior.
Testing:
Add a root certificate that does not have the expected basicConstraints extension with the cA bit set to true. This certificate would be rejected by OpenSSL, but is currently allowed to be trusted by AWS-LC due to it being in the trust store.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.