Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LibRdKafka to our CI #2225

Merged
merged 18 commits into from
Mar 7, 2025
Merged

Add LibRdKafka to our CI #2225

merged 18 commits into from
Mar 7, 2025

Conversation

smittals2
Copy link
Contributor

@smittals2 smittals2 commented Feb 27, 2025

Issues:

CryptoAlg-2863

Description of changes:

Add librdkafka upstream to our CI. Tests require spinning up a kafka cluster which is proving problematic in our codebuild environment. Currently not running kafka tests in this CI check.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@smittals2 smittals2 requested a review from a team as a code owner February 27, 2025 01:12
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (4fb8ec3) to head (a21e432).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2225   +/-   ##
=======================================
  Coverage   79.05%   79.05%           
=======================================
  Files         612      612           
  Lines      106517   106517           
  Branches    15053    15053           
=======================================
+ Hits        84204    84207    +3     
+ Misses      21661    21658    -3     
  Partials      652      652           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@smittals2 smittals2 changed the title Kafka ci Add LibRdKafka to our CI Feb 27, 2025
justsmth
justsmth previously approved these changes Feb 28, 2025
Copy link
Contributor

@justsmth justsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... spinning up a kafka cluster which is proving problematic in our codebuild environment.

Would it be easier using GitHub actions? Having the tests run would provide a lot more value than just confirming that the build succeeds.

@smittals2 smittals2 requested review from andrewhop and justsmth March 3, 2025 19:19
justsmth
justsmth previously approved these changes Mar 5, 2025
@smittals2 smittals2 merged commit 5054cf0 into aws:main Mar 7, 2025
106 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants