-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LibRdKafka to our CI #2225
Add LibRdKafka to our CI #2225
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2225 +/- ##
=======================================
Coverage 79.05% 79.05%
=======================================
Files 612 612
Lines 106517 106517
Branches 15053 15053
=======================================
+ Hits 84204 84207 +3
+ Misses 21661 21658 -3
Partials 652 652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... spinning up a kafka cluster which is proving problematic in our codebuild environment.
Would it be easier using GitHub actions? Having the tests run would provide a lot more value than just confirming that the build succeeds.
Issues:
CryptoAlg-2863
Description of changes:
Add librdkafka upstream to our CI. Tests require spinning up a kafka cluster which is proving problematic in our codebuild environment. Currently not running kafka tests in this CI check.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.