Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify IsFlag check logic #2209

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Simplify IsFlag check logic #2209

merged 1 commit into from
Feb 19, 2025

Conversation

skmcgrail
Copy link
Member

Issues:

Resolves P194739376

Description of changes:

There was some logically dead code that was unnecessary and would never be reached.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner February 19, 2025 19:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.07%. Comparing base (ead47e8) to head (c32472e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2209      +/-   ##
==========================================
+ Coverage   79.04%   79.07%   +0.03%     
==========================================
  Files         612      612              
  Lines      106222   106222              
  Branches    15008    15008              
==========================================
+ Hits        83959    83992      +33     
+ Misses      21612    21579      -33     
  Partials      651      651              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skmcgrail skmcgrail merged commit 82a16b6 into aws:main Feb 19, 2025
116 of 119 checks passed
@skmcgrail skmcgrail deleted the coverity branch February 19, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants