Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AWSLC_SOURCE_DIR and AWSLC_BINARY_DIR #2208

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

justsmth
Copy link
Contributor

Description of changes:

Call-outs:

  • No change to logic. The change is a simple text substitution.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.06%. Comparing base (ead47e8) to head (9f10262).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2208      +/-   ##
==========================================
+ Coverage   79.04%   79.06%   +0.02%     
==========================================
  Files         612      612              
  Lines      106222   106222              
  Branches    15008    15007       -1     
==========================================
+ Hits        83959    83984      +25     
+ Misses      21612    21587      -25     
  Partials      651      651              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth marked this pull request as ready for review February 19, 2025 21:48
@justsmth justsmth requested a review from a team as a code owner February 19, 2025 21:48
Copy link
Contributor

@andrewhop andrewhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this causing an issue? Is it worth putting some pre-push check that ensures there are no PROJECT variables in our CMakeList?

@justsmth
Copy link
Contributor Author

Was this causing an issue? Is it worth putting some pre-push check that ensures there are no PROJECT variables in our CMakeList?

I don't think it was causing any actual problems for us. I noticed it while debugging a build issue and I got concerned about which "project" was in context. The use of PROJECT_SOURCE_DIR is a potential source of ambiguity when working with third-party libraries (like jitterentropy).

@justsmth justsmth merged commit 9e80f0a into aws:main Feb 26, 2025
117 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants