Add guidance around certificate auto-chaining in TLS #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2205 +/- ##
==========================================
+ Coverage 79.04% 79.06% +0.01%
==========================================
Files 612 612
Lines 106164 106327 +163
Branches 15003 15023 +20
==========================================
+ Hits 83921 84071 +150
- Misses 21590 21605 +15
+ Partials 653 651 -2 ☔ View full report in Codecov by Sentry. |
samuel40791765
previously approved these changes
Feb 19, 2025
darylmartin100
previously approved these changes
Feb 20, 2025
nebeid
reviewed
Feb 20, 2025
Co-authored-by: Nevine Ebeid <66388554+nebeid@users.noreply.github.com>
skmcgrail
dismissed stale reviews from darylmartin100 and samuel40791765
via
a93ca2c
nebeid
approved these changes
Feb 24, 2025
samuel40791765
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses V1612276057
Description of changes:
Add clear documentation around AWS-LC's default behavior of disabling certificate auto-chaining and it's impact TLS client and server certificates present over the wire.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.