Update ABI Diff Action to work correctly on push events #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2188 +/- ##
==========================================
- Coverage 79.04% 79.03% -0.01%
==========================================
Files 612 612
Lines 106064 106064
Branches 14994 14995 +1
==========================================
- Hits 83833 83825 -8
- Misses 21579 21587 +8
Partials 652 652 ☔ View full report in Codecov by Sentry. |
skmcgrail
changed the title
smittals2
approved these changes
Feb 12, 2025
justsmth
reviewed
Feb 18, 2025
| @@ -19,12 +19,12 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| with: | |||
| repository: aws/aws-lc | |||
| ref: ${{ github.ref }} | |||
| ref: ${{ github.event_name == 'push' && github.event.ref || github.event.pull_request.head.sha }} | |||
There was a problem hiding this comment.
NP: Are parenthesis needed here and below?
ref: ${{ (github.event_name == 'push' && github.event.ref) || github.event.pull_request.head.sha }}
There was a problem hiding this comment.
GitHub doesn't seem to outright state precedence order for evaluation, but it appears to be left-to-right. See the example here that is basically the same as the line I have: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#example
justsmth
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.