Add MLDSA to fuzzing corpus #2174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2174 +/- ##
=======================================
Coverage 79.02% 79.02%
=======================================
Files 612 612
Lines 106064 106064
Branches 14982 14984 +2
=======================================
+ Hits 83819 83820 +1
Misses 21592 21592
+ Partials 653 652 -1 ☔ View full report in Codecov by Sentry. |
andrewhop
previously approved these changes
Feb 7, 2025
|
Closed and picked up in #2191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #PQCrypto-120
Description of changes:
This PR updates the fuzz tests to include seeds based upon ML-DSA private key encodings. I provided manual seeds to the corpus to fuzz specifically against private key import.
Seed1: ML-DSA-44 private key in seed representation:
Seed2 ML-DSA-65 private key in seed representation:
Seed3: ML-DSA-87 private key in seed representation:
Seed4: ML-DSA-44 private key in full representation:
Seed5: ML-DSA-65 private key in full representation:
Seed6: ML-DSA-87 private key in full representation:
Methodology:
./fuzz/pkcs8 -max_len=2048 -jobs=32 -workers=32 mldsa-seed/./fuzz/pkcs8 -merge=1 min-corpus/ mldsa-seed/./fuzz/pkcs8 -merge=1 merged/ min-corpus/ ../fuzz/pkcs8_corpus/Call-outs:
Wasn't able to get a coverage report from https://github.com/aws/aws-lc/blob/main/docs/Coverage.md as
lcovdidn't want to play withclang.We were at
231fuzz vectors inpkcs8_corpusand now we are at321.Testing:
Testing coverage was tested by introducing an error (emulated #2152). These tests caught the error.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.