Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SSL_CIPHER_get_version for recent TLS versions #1627

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

WillChilds-Klein
Copy link
Contributor

Issues:

Resolves t-V1408365647
Addresses n/a

Description of changes:

This change modifies SSL_CIPHER_get_version to return the relevant version for non-deprecated TLS versions, namely TLSv1.2 and TLSv1.3 (preferred). For older TLS versions, the previous behavior (return constant cstring TLSv1/SSLv3) is preserved.

Call-outs:

  • n/a

Testing:

  • CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.09%. Comparing base (4013299) to head (20fbb44).

Files Patch % Lines
ssl/ssl_cipher.cc 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
+ Coverage   78.07%   78.09%   +0.01%     
==========================================
  Files         562      562              
  Lines       94656    94666      +10     
  Branches    13573    13573              
==========================================
+ Hits        73900    73925      +25     
+ Misses      20162    20146      -16     
- Partials      594      595       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review June 7, 2024 17:53
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner June 7, 2024 17:53
@andrewhop andrewhop merged commit 3b19b5a into aws:main Jun 7, 2024
95 of 98 checks passed
@WillChilds-Klein WillChilds-Klein deleted the impl-SSL_CIPHER_get_version branch June 7, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants