Revert _CET_ENDBR (#1656)

### Description of changes: Revert: * #1641 * #1628 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
aws · Jun 21, 2024 · b681bb0 · b681bb0
1 parent c1c4383
commit b681bb0
Show file tree

Hide file tree

Showing 82 changed files with 0 additions and 470 deletions.
diff --git a/crypto/chacha/asm/chacha-x86_64.pl b/crypto/chacha/asm/chacha-x86_64.pl
@@ -235,7 +235,6 @@ sub ROUND {			# critical path is 24 cycles per round
 .align	64
 ChaCha20_ctr32:
 .cfi_startproc
-	_CET_ENDBR
 	cmp	\$0,$len
 	je	.Lno_data
 	mov	OPENSSL_ia32cap_P+4(%rip),%r10

diff --git a/crypto/cipher_extra/asm/aes128gcmsiv-x86_64.pl b/crypto/cipher_extra/asm/aes128gcmsiv-x86_64.pl
@@ -140,7 +140,6 @@ sub aesgcmsiv_htable_init {
 .align 16
 aesgcmsiv_htable_init:
 .cfi_startproc
-    _CET_ENDBR
     vmovdqa ($H), $T
     vmovdqa $T, $TMP0
     vmovdqa $T, ($Htbl)      # H
@@ -181,7 +180,6 @@ sub aesgcmsiv_htable6_init {
 .align 16
 aesgcmsiv_htable6_init:
 .cfi_startproc
-    _CET_ENDBR
     vmovdqa ($H), $T
     vmovdqa $T, $TMP0
     vmovdqa $T, ($Htbl)      # H
@@ -243,7 +241,6 @@ sub aesgcmsiv_htable_polyval {
 .align 16
 aesgcmsiv_htable_polyval:
 .cfi_startproc
-    _CET_ENDBR
     test  $len, $len
     jnz   .Lhtable_polyval_start
     ret
@@ -429,7 +426,6 @@ sub aesgcmsiv_polyval_horner {
 .align 16
 aesgcmsiv_polyval_horner:
 .cfi_startproc
-    _CET_ENDBR
     test $L, $L
     jnz .Lpolyval_horner_start
     ret
@@ -470,7 +466,6 @@ sub aesgcmsiv_polyval_horner {
 .align 16
 aes128gcmsiv_aes_ks:
 .cfi_startproc
-    _CET_ENDBR
     vmovdqu (%rdi), %xmm1           # xmm1 = user key
     vmovdqa %xmm1, (%rsi)           # rsi points to output
 
@@ -532,7 +527,6 @@ sub aesgcmsiv_polyval_horner {
 .align 16
 aes256gcmsiv_aes_ks:
 .cfi_startproc
-    _CET_ENDBR
     vmovdqu (%rdi), %xmm1
     vmovdqu 16(%rdi), %xmm3
     vmovdqa %xmm1, (%rsi)
@@ -626,7 +620,6 @@ sub aes128gcmsiv_aes_ks_enc_x1 {
 .align 16
 aes128gcmsiv_aes_ks_enc_x1:
 .cfi_startproc
-    _CET_ENDBR
     vmovdqa (%rcx), %xmm1                 # xmm1 = first 16 bytes of random key
     vmovdqa 0*16(%rdi), $BLOCK1
 
@@ -700,7 +693,6 @@ sub aes128gcmsiv_kdf {
 .align 16
 aes128gcmsiv_kdf:
 .cfi_startproc
-    _CET_ENDBR
 # parameter 1: %rdi                         Pointer to NONCE
 # parameter 2: %rsi                         Pointer to CT
 # parameter 4: %rdx                         Pointer to keys
@@ -801,7 +793,6 @@ sub aes128gcmsiv_enc_msg_x4 {
 .align 16
 aes128gcmsiv_enc_msg_x4:
 .cfi_startproc
-    _CET_ENDBR
     test $LEN, $LEN
     jnz .L128_enc_msg_x4_start
     ret
@@ -999,7 +990,6 @@ sub aes128gcmsiv_enc_msg_x8 {
 .align 16
 aes128gcmsiv_enc_msg_x8:
 .cfi_startproc
-    _CET_ENDBR
     test $LEN, $LEN
     jnz .L128_enc_msg_x8_start
     ret
@@ -1255,7 +1245,6 @@ sub aesgcmsiv_dec {
 
   $code.=<<___;
 .cfi_startproc
-    _CET_ENDBR
     test \$~15, $LEN
     jnz .L${labelPrefix}_dec_start
     ret
@@ -1595,7 +1584,6 @@ sub aes128gcmsiv_ecb_enc_block {
 .align 16
 aes128gcmsiv_ecb_enc_block:
 .cfi_startproc
-    _CET_ENDBR
     vmovdqa (%rdi), $STATE_1
 
     vpxor       ($KSp), $STATE_1, $STATE_1
@@ -1688,7 +1676,6 @@ sub aes256gcmsiv_aes_ks_enc_x1 {
 .align 16
 aes256gcmsiv_aes_ks_enc_x1:
 .cfi_startproc
-    _CET_ENDBR
     vmovdqa con1(%rip), $CON_MASK    # CON_MASK  = 1,1,1,1
     vmovdqa mask(%rip), $MASK_256    # MASK_256
     vmovdqa ($PT), $BLOCK1
@@ -1730,7 +1717,6 @@ sub aes256gcmsiv_ecb_enc_block {
 .align 16
 aes256gcmsiv_ecb_enc_block:
 .cfi_startproc
-    _CET_ENDBR
     vmovdqa (%rdi), $STATE_1
     vpxor ($KSp), $STATE_1, $STATE_1
     vaesenc 1*16($KSp), $STATE_1, $STATE_1
@@ -1814,7 +1800,6 @@ sub aes256gcmsiv_enc_msg_x4 {
 .align 16
 aes256gcmsiv_enc_msg_x4:
 .cfi_startproc
-    _CET_ENDBR
     test $LEN, $LEN
     jnz .L256_enc_msg_x4_start
     ret
@@ -2015,7 +2000,6 @@ ()
 .align 16
 aes256gcmsiv_enc_msg_x8:
 .cfi_startproc
-    _CET_ENDBR
     test $LEN, $LEN
     jnz .L256_enc_msg_x8_start
     ret
@@ -2222,7 +2206,6 @@ sub aes256gcmsiv_kdf {
 .align 16
 aes256gcmsiv_kdf:
 .cfi_startproc
-    _CET_ENDBR
 # parameter 1: %rdi                         Pointer to NONCE
 # parameter 2: %rsi                         Pointer to CT
 # parameter 4: %rdx                         Pointer to keys

diff --git a/crypto/cipher_extra/asm/chacha20_poly1305_x86_64.pl b/crypto/cipher_extra/asm/chacha20_poly1305_x86_64.pl
@@ -453,7 +453,6 @@ sub emit_body {
 .align 64
 chacha20_poly1305_open:
 .cfi_startproc
-    _CET_ENDBR
     push %rbp
 .cfi_push %rbp
     push %rbx
@@ -876,7 +875,6 @@ sub emit_body {
 .align 64
 chacha20_poly1305_seal:
 .cfi_startproc
-    _CET_ENDBR
     push %rbp
 .cfi_push %rbp
     push %rbx

diff --git a/crypto/fipsmodule/aes/asm/aesni-x86_64.pl b/crypto/fipsmodule/aes/asm/aesni-x86_64.pl
@@ -278,7 +278,6 @@ sub aesni_generate1 {
 .align	16
 ${PREFIX}_encrypt:
 .cfi_startproc
-	_CET_ENDBR
 #ifdef BORINGSSL_DISPATCH_TEST
 .extern	BORINGSSL_function_hit
 	movb \$1,BORINGSSL_function_hit+1(%rip)
@@ -301,7 +300,6 @@ sub aesni_generate1 {
 .align	16
 ${PREFIX}_decrypt:
 .cfi_startproc
-	_CET_ENDBR
 	movups	($inp),$inout0		# load input
 	mov	240($key),$rounds	# key->rounds
 ___
@@ -622,7 +620,6 @@ sub aesni_generate8 {
 .align	16
 ${PREFIX}_ecb_encrypt:
 .cfi_startproc
-	_CET_ENDBR
 ___
 $code.=<<___ if ($win64);
 	lea	-0x58(%rsp),%rsp
@@ -1209,7 +1206,6 @@ sub aesni_generate8 {
 .align	16
 ${PREFIX}_ctr32_encrypt_blocks:
 .cfi_startproc
-	_CET_ENDBR
 #ifdef BORINGSSL_DISPATCH_TEST
 	movb \$1,BORINGSSL_function_hit(%rip)
 #endif
@@ -1788,7 +1784,6 @@ sub aesni_generate8 {
 .align	16
 ${PREFIX}_xts_encrypt:
 .cfi_startproc
-	_CET_ENDBR
 	lea	(%rsp),%r11			# frame pointer
 .cfi_def_cfa_register	%r11
 	push	%rbp
@@ -2272,7 +2267,6 @@ sub aesni_generate8 {
 .align	16
 ${PREFIX}_xts_decrypt:
 .cfi_startproc
-	_CET_ENDBR
 	lea	(%rsp),%r11			# frame pointer
 .cfi_def_cfa_register	%r11
 	push	%rbp
@@ -2791,7 +2785,6 @@ sub aesni_generate8 {
 .align	16
 ${PREFIX}_cbc_encrypt:
 .cfi_startproc
-	_CET_ENDBR
 	test	$len,$len		# check length
 	jz	.Lcbc_ret
 
@@ -3341,7 +3334,6 @@ sub aesni_generate8 {
 .align	16
 ${PREFIX}_set_decrypt_key:
 .cfi_startproc
-	_CET_ENDBR
 	.byte	0x48,0x83,0xEC,0x08	# sub rsp,8
 .cfi_adjust_cfa_offset	8
 	call	__aesni_set_encrypt_key
@@ -3414,7 +3406,6 @@ sub aesni_generate8 {
 ${PREFIX}_set_encrypt_key:
 __aesni_set_encrypt_key:
 .cfi_startproc
-	_CET_ENDBR
 #ifdef BORINGSSL_DISPATCH_TEST
 	movb \$1,BORINGSSL_function_hit+3(%rip)
 #endif

diff --git a/crypto/fipsmodule/aes/asm/vpaes-x86_64.pl b/crypto/fipsmodule/aes/asm/vpaes-x86_64.pl
@@ -874,7 +874,6 @@
 .align	16
 ${PREFIX}_set_encrypt_key:
 .cfi_startproc
-	_CET_ENDBR
 #ifdef BORINGSSL_DISPATCH_TEST
 .extern        BORINGSSL_function_hit
        movb \$1, BORINGSSL_function_hit+5(%rip)
@@ -930,7 +929,6 @@
 .align	16
 ${PREFIX}_set_decrypt_key:
 .cfi_startproc
-	_CET_ENDBR
 ___
 $code.=<<___ if ($win64);
 	lea	-0xb8(%rsp),%rsp
@@ -986,7 +984,6 @@
 .align	16
 ${PREFIX}_encrypt:
 .cfi_startproc
-	_CET_ENDBR
 #ifdef BORINGSSL_DISPATCH_TEST
 .extern        BORINGSSL_function_hit
        movb \$1, BORINGSSL_function_hit+4(%rip)
@@ -1036,7 +1033,6 @@
 .align	16
 ${PREFIX}_decrypt:
 .cfi_startproc
-	_CET_ENDBR
 ___
 $code.=<<___ if ($win64);
 	lea	-0xb8(%rsp),%rsp
@@ -1088,7 +1084,6 @@
 .align	16
 ${PREFIX}_cbc_encrypt:
 .cfi_startproc
-	_CET_ENDBR
 	xchg	$key,$len
 ___
 ($len,$key)=($key,$len);
@@ -1174,7 +1169,6 @@
 .align	16
 ${PREFIX}_ctr32_encrypt_blocks:
 .cfi_startproc
-	_CET_ENDBR
 	# _vpaes_encrypt_core and _vpaes_encrypt_core_2x expect the key in %rdx.
 	xchg	$key, $blocks
 ___

diff --git a/crypto/fipsmodule/bn/asm/rsaz-avx2.pl b/crypto/fipsmodule/bn/asm/rsaz-avx2.pl
@@ -116,7 +116,6 @@
 .align	64
 rsaz_1024_sqr_avx2:		# 702 cycles, 14% faster than rsaz_1024_mul_avx2
 .cfi_startproc
-	_CET_ENDBR
 	lea	(%rsp), %rax
 .cfi_def_cfa_register	%rax
 	push	%rbx
@@ -868,7 +867,6 @@
 .align	64
 rsaz_1024_mul_avx2:
 .cfi_startproc
-	_CET_ENDBR
 	lea	(%rsp), %rax
 .cfi_def_cfa_register	%rax
 	push	%rbx
@@ -1480,7 +1478,6 @@
 .align	32
 rsaz_1024_red2norm_avx2:
 .cfi_startproc
-	_CET_ENDBR
 	sub	\$-128,$inp	# size optimization
 	xor	%rax,%rax
 ___
@@ -1522,7 +1519,6 @@
 .align	32
 rsaz_1024_norm2red_avx2:
 .cfi_startproc
-	_CET_ENDBR
 	sub	\$-128,$out	# size optimization
 	mov	($inp),@T[0]
 	mov	\$0x1fffffff,%eax
@@ -1567,7 +1563,6 @@
 .align	32
 rsaz_1024_scatter5_avx2:
 .cfi_startproc
-	_CET_ENDBR
 	vzeroupper
 	vmovdqu	.Lscatter_permd(%rip),%ymm5
 	shl	\$4,$power
@@ -1595,7 +1590,6 @@
 .align	32
 rsaz_1024_gather5_avx2:
 .cfi_startproc
-	_CET_ENDBR
 	vzeroupper
 	mov	%rsp,%r11
 .cfi_def_cfa_register	%r11

diff --git a/crypto/fipsmodule/bn/asm/x86_64-mont.pl b/crypto/fipsmodule/bn/asm/x86_64-mont.pl
@@ -96,7 +96,6 @@
 .align	16
 bn_mul_mont:
 .cfi_startproc
-	_CET_ENDBR
 	mov	${num}d,${num}d
 	mov	%rsp,%rax
 .cfi_def_cfa_register	%rax

diff --git a/crypto/fipsmodule/bn/asm/x86_64-mont5.pl b/crypto/fipsmodule/bn/asm/x86_64-mont5.pl
@@ -83,7 +83,6 @@
 .align	64
 bn_mul_mont_gather5:
 .cfi_startproc
-	_CET_ENDBR
 	mov	${num}d,${num}d
 	mov	%rsp,%rax
 .cfi_def_cfa_register	%rax
@@ -1103,7 +1102,6 @@
 .align	32
 bn_power5:
 .cfi_startproc
-	_CET_ENDBR
 	mov	%rsp,%rax
 .cfi_def_cfa_register	%rax
 ___
@@ -1246,7 +1244,6 @@
 bn_sqr8x_internal:
 __bn_sqr8x_internal:
 .cfi_startproc
-	_CET_ENDBR
 	##############################################################
 	# Squaring part:
 	#
@@ -2744,7 +2741,6 @@
 bn_sqrx8x_internal:
 __bn_sqrx8x_internal:
 .cfi_startproc
-	_CET_ENDBR
 	##################################################################
 	# Squaring part:
 	#
@@ -3456,7 +3452,6 @@
 .align	16
 bn_scatter5:
 .cfi_startproc
-	_CET_ENDBR
 	cmp	\$0, $num
 	jz	.Lscatter_epilogue
 
@@ -3487,7 +3482,6 @@
 bn_gather5:
 .cfi_startproc
 .LSEH_begin_bn_gather5:			# Win64 thing, but harmless in other cases
-	_CET_ENDBR
 	# I can't trust assembler to use specific encoding:-(
 	.byte	0x4c,0x8d,0x14,0x24			#lea    (%rsp),%r10
 .cfi_def_cfa_register	%r10