Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Ed25519PublicKey #695

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Expose Ed25519PublicKey #695

merged 2 commits into from
Feb 13, 2025

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Feb 12, 2025

Description of changes:

  • Exposes the Ed25519PublicKey type.

Call-outs:

Testing:

  • Updated our testing to better cover this API.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner February 12, 2025 14:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (c358484) to head (f87232e).
Report is 167 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   95.80%   92.89%   -2.91%     
==========================================
  Files          61       69       +8     
  Lines        8143     9565    +1422     
  Branches        0     9565    +9565     
==========================================
+ Hits         7801     8885    +1084     
- Misses        342      399      +57     
- Partials        0      281     +281     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit 5337f14 into aws:main Feb 13, 2025
256 of 264 checks passed
@justsmth justsmth deleted the ed25519-public-key branch February 13, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants