Separate graphQL schema from resolver #79
+24
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
reviewed
Mar 12, 2025
…e in schema file as separate file instead of input, made template static by not accepting any input except the timestamp
flora-jin
force-pushed
the
schemaFromResolver
branch
from
f908c10 to
0c39673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current graphQL utility has a resolver template file with a placeholder for the graphQL schema. During runtime, the utility replaces the placeholder with the schema and then includes the resulting resolver schema in the zip contents that are deployed to AWS lambda.
However, this logic makes it difficult to unit test so the pull request includes code changes where the schema is separated from the resolver. Instead of the resolver template having a placeholder for the schema, it instead takes in the schema as a separate file that is deployed with the other files in the zip file.