Apollo zip from input schema file #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreachild
changed the title
kmcginnes
reviewed
Feb 21, 2025
kmcginnes
reviewed
Feb 21, 2025
kmcginnes
reviewed
Feb 21, 2025
| @@ -146,6 +146,8 @@ Parameters | |||
|
|
|||
| [--create-update-apollo-server -asvr] | |||
| [--create-update-apollo-server-subgraph -asub] | |||
| [--create-update-apollo-server-neptune-endpoint -ase ] default: --input-graphdb-schema-neptune-endpoint if exists | |||
| [ ... more apollo options to come in future roadmap ] | |||
There was a problem hiding this comment.
I know we accidentally missed a spot with the help text last time. Just double checking if we got them all this time.
I don't know what all of them are, so I'm just posing the question to you.
There was a problem hiding this comment.
I think I got it all this time!
kmcginnes
reviewed
Feb 21, 2025
xiazcy
reviewed
Feb 21, 2025
xiazcy
reviewed
Feb 21, 2025
xiazcy
reviewed
Feb 21, 2025
xiazcy
reviewed
Feb 21, 2025
xiazcy
reviewed
Feb 21, 2025
xiazcy
reviewed
Feb 21, 2025
… instead of discovering the schema by querying neptune. For consistency with App Sync pipeline and CDK workflows, this workflow requires setting a new endpoint argument --create-update-apollo-server-neptune-endpoint in addition to the existing --input-schema-file argument. Other changes: -fixed bugs resolving gremlin queries and added resolver tests for these scenarios -changed schema file in zip to have output. prefix for consistency with the resolver file -bumped the version from 1.1.1 to 1.2.0-beta.1
andreachild
force-pushed
the
apolloStartFromSchema
branch
from
81caa09 to
f4c1163
Compare
xiazcy
approved these changes
Feb 21, 2025
kmcginnes
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #67
Description of changes:
Added ability to create Apollo zip using an input graphQL schema file instead of discovering the schema by querying neptune. For consistency with App Sync pipeline and CDK workflows, this workflow requires setting a new endpoint argument
--create-update-apollo-server-neptune-endpointin addition to the existing--input-schema-fileargument.Other changes:
output.prefix for consistency with the resolver fileBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.