Honour @id directive on type fields
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `@id` directive was specified on a field, it was ignored by `schemaModelValidator` which added a new ID field, resulting in 2 ID fields. Now, the directive inference checks for the existence of an ID field before adding the default one. - break out logic around ID/input fields into dedicated functions - better inlining of input fields and values closes aws#59
|
Looks good to me! +1 |
andreachild
reviewed
Jan 27, 2025
|
LGTM |
Cole-Greer
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #59
Description of changes:
When the
@iddirective was specified on a field, it was ignored byschemaModelValidatorwhich added a new ID field, resulting in 2 ID fields.Now, the directive inference checks for the existence of an ID field before adding the default one.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.