Change integration tests to use injected environment variables #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcginnes
reviewed
Oct 11, 2024
kmcginnes
approved these changes
Oct 11, 2024
andreachild
force-pushed
the
achild/testCases
branch
2 times, most recently
from
1806ac5 to
b53cc03
Compare
…rences to use a common file. Changed integration test references to neptune db host and port to have values injected from environment variables so that contributors do not have to modify the case files to execute tests, which could lead to accidental commit of real URLs. Fixed tests failing due to hardcoded output directory reference in main.js, missing comma in json file, typo in referenced file suffix, and incorrect order of test cases (delete, create changed to create, delete).
andreachild
force-pushed
the
achild/testCases
branch
from
b53cc03 to
9085556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicates of airports.source.schema.graphql and changed references to use a common file. Changed integration test references to neptune db host and port to have values injected from environment variables so that contributors do not have to modify the case files to execute tests, which could lead to accidental commit of real URLs.
Fixed tests failing due to missing comma in json file, typo in referenced file suffix, and incorrect order of test cases (delete, create changed to create, delete).