Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_based_prediction): add diagnostic handler to warn the processing time excess #10219

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

feat: add validation for consecutive delay time

1f0cfdf
Select commit
Loading
Failed to load commit list.
Open

feat(map_based_prediction): add diagnostic handler to warn the processing time excess #10219

feat: add validation for consecutive delay time
1f0cfdf
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 26, 2025 in 53s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Prevent hotspot decline (1 hotspot with Complex Method, Large Method)
Enforce advisory code health rules (1 file with Complex Method, Large Method)

Gates Passed
2 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Prevent hotspot decline Violations Code Health Impact
map_based_prediction_node.cpp 2 rules in this hotspot 3.74 → 3.71 Suppress
Enforce advisory code health rules Violations Code Health Impact
map_based_prediction_node.cpp 2 advisory rules 3.74 → 3.71 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method map_based_prediction_node.cpp: MapBasedPredictionNode::MapBasedPredictionNode 🔥
  • Complex Method map_based_prediction_node.cpp: MapBasedPredictionNode::objectsCallback 🔥

✅ Improving Code Health:

  • Overall Code Complexity map_based_prediction_node.cpp 🔥

Annotations

Check warning on line 740 in perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

MapBasedPredictionNode::objectsCallback increases in cyclomatic complexity from 20 to 21, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 522 in perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

MapBasedPredictionNode::MapBasedPredictionNode increases from 120 to 129 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1 in perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 6.85 to 6.76, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.