-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
behavior path planner dies in endless getLeftMostLineString
recursion
#5632
Comments
I got the same crash today after setting a new goal point. The route handler died after 52000 recursions I was too clumsy to find the root cause with gdb this time, but from the backtrace and the code, I can think of 2 cases:
I am surprised how seldom this bug is (3rd time I see it over 2 weeks). So I guess it might be related to the start/goal point. The lanelet map is just a big one way loop, with sometimes multiple lanes, sometimes a road shoulder on the left, and a few crosswalk. I don't see how such recursion could happen. In any case, I don't think it is sane to keep unbounded recursion like this one in the code. Most roads are only a few lanelets wide, so it would not be very costy to keep a list of all explored lanelets and stop if a loop is detected. |
What I managed to scrape:
|
This pull request has been automatically marked as stale because it has not had recent activity. |
@VRichardJP However, I'm still curious about the conditions under which the recursion occurs and which part of the process is causing the issue. So, how about providing information that could help reproduce the problem and adding a "help-wanted" tag? |
@kyoichi-sugahara I usually don't enable this kind of advanced module (because too risky), except from time to time during the vehicle integration to test a bit. So it is possible the crash has only ever happened with that module (normal lane change has never been an issue). I have no use for AvoidanceByLaneChange in other projects at the moment so I can't allocate much time to debug this either. |
The function in which the endless recursion occurred is no longer used anywhere in the latest version and has been removed along with other obsolete functions in a recent PR. so this issue can be closed. |
@mkquda |
Checklist
Description
Sorry for the lack of information (yet)
I have caught this crash of the behavior path planner container with gdb:
My map is just a big circular loop, with sometimes multiple lanes and some cross walks (nothing fancy).
It might be the same crash as in #5631
I will update when I have more information.
Expected behavior
Never crash
Actual behavior
crash
Steps to reproduce
Stay tuned
Versions
No response
Possible causes
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: