Skip to content

Commit f096ecd

Browse files
committed
revert: revert change in probabilistic_occupancy_grid_map
Signed-off-by: kminoda <koji.minoda@tier4.jp>
1 parent 02f7f4a commit f096ecd

File tree

4 files changed

+33
-2
lines changed

4 files changed

+33
-2
lines changed

perception/probabilistic_occupancy_grid_map/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ Additional argument is shown below:
6767
| `map_origin` | `` | parameter to override `map_origin_frame` which means grid map origin |
6868
| `scan_origin` | `` | parameter to override `scan_origin_frame` which means scanning center |
6969
| `output` | `occupancy_grid` | output name |
70+
| `use_pointcloud_container` | `false` | |
7071
| `container_name` | `occupancy_grid_map_container` | |
7172
| `input_obstacle_pointcloud` | `false` | only for laserscan based method. If true, the node subscribe obstacle pointcloud |
7273
| `input_obstacle_and_raw_pointcloud` | `true` | only for laserscan based method. If true, the node subscribe both obstacle and raw pointcloud |

perception/probabilistic_occupancy_grid_map/launch/laserscan_based_occupancy_grid_map.launch.py

+15-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
from launch.conditions import IfCondition
2121
from launch.conditions import UnlessCondition
2222
from launch.substitutions import LaunchConfiguration
23+
from launch_ros.actions import ComposableNodeContainer
2324
from launch_ros.actions import LoadComposableNodes
2425
from launch_ros.descriptions import ComposableNode
2526
import yaml
@@ -113,12 +114,23 @@ def launch_setup(context, *args, **kwargs):
113114
),
114115
]
115116

117+
occupancy_grid_map_container = ComposableNodeContainer(
118+
name=LaunchConfiguration("individual_container_name"),
119+
namespace="",
120+
package="rclcpp_components",
121+
executable=LaunchConfiguration("container_executable"),
122+
composable_node_descriptions=composable_nodes,
123+
condition=UnlessCondition(LaunchConfiguration("use_pointcloud_container")),
124+
output="screen",
125+
)
126+
116127
load_composable_nodes = LoadComposableNodes(
117128
composable_node_descriptions=composable_nodes,
118129
target_container=LaunchConfiguration("pointcloud_container_name"),
130+
condition=IfCondition(LaunchConfiguration("use_pointcloud_container")),
119131
)
120132

121-
return [load_composable_nodes]
133+
return [occupancy_grid_map_container, load_composable_nodes]
122134

123135

124136
def generate_launch_description():
@@ -161,7 +173,9 @@ def add_launch_arg(name: str, default_value=None):
161173
),
162174
add_launch_arg("input_obstacle_pointcloud", "false"),
163175
add_launch_arg("input_obstacle_and_raw_pointcloud", "true"),
176+
add_launch_arg("use_pointcloud_container", "false"),
164177
add_launch_arg("pointcloud_container_name", "pointcloud_container"),
178+
add_launch_arg("individual_container_name", "occupancy_grid_map_container"),
165179
set_container_executable,
166180
set_container_mt_executable,
167181
]

perception/probabilistic_occupancy_grid_map/launch/pointcloud_based_occupancy_grid_map.launch.py

+15-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
from launch.conditions import IfCondition
2121
from launch.conditions import UnlessCondition
2222
from launch.substitutions import LaunchConfiguration
23+
from launch_ros.actions import ComposableNodeContainer
2324
from launch_ros.actions import LoadComposableNodes
2425
from launch_ros.descriptions import ComposableNode
2526
import yaml
@@ -62,12 +63,23 @@ def launch_setup(context, *args, **kwargs):
6263
),
6364
]
6465

66+
occupancy_grid_map_container = ComposableNodeContainer(
67+
name=LaunchConfiguration("individual_container_name"),
68+
namespace="",
69+
package="rclcpp_components",
70+
executable=LaunchConfiguration("container_executable"),
71+
composable_node_descriptions=composable_nodes,
72+
condition=UnlessCondition(LaunchConfiguration("use_pointcloud_container")),
73+
output="screen",
74+
)
75+
6576
load_composable_nodes = LoadComposableNodes(
6677
composable_node_descriptions=composable_nodes,
6778
target_container=LaunchConfiguration("pointcloud_container_name"),
79+
condition=IfCondition(LaunchConfiguration("use_pointcloud_container")),
6880
)
6981

70-
return [load_composable_nodes]
82+
return [occupancy_grid_map_container, load_composable_nodes]
7183

7284

7385
def generate_launch_description():
@@ -90,7 +102,9 @@ def add_launch_arg(name: str, default_value=None):
90102
[
91103
add_launch_arg("use_multithread", "false"),
92104
add_launch_arg("use_intra_process", "true"),
105+
add_launch_arg("use_pointcloud_container", "false"),
93106
add_launch_arg("pointcloud_container_name", "pointcloud_container"),
107+
add_launch_arg("individual_container_name", "occupancy_grid_map_container"),
94108
add_launch_arg("input/obstacle_pointcloud", "no_ground/oneshot/pointcloud"),
95109
add_launch_arg("input/raw_pointcloud", "concatenated/pointcloud"),
96110
add_launch_arg("output", "occupancy_grid"),

perception/probabilistic_occupancy_grid_map/synchronized_grid_map_fusion.md

+2
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ You need to generate OGMs in each sensor frame before achieving grid map fusion.
104104
<arg name="scan_origin" value="velodyne_right"/>
105105
<arg name="use_intra_process" value="true"/>
106106
<arg name="use_multithread" value="true"/>
107+
<arg name="use_pointcloud_container" value="$(var use_pointcloud_container)"/>
107108
<arg name="pointcloud_container_name" value="$(var pointcloud_container_name)"/>
108109
<arg name="method" value="pointcloud_based_occupancy_grid_map"/>
109110
<arg name="param_file" value="$(find-pkg-share probabilistic_occupancy_grid_map)/config/pointcloud_based_occupancy_grid_map_fusion.param.yaml"/>
@@ -144,6 +145,7 @@ You can include this launch file like the following.
144145
<arg name="output" value="/perception/occupancy_grid_map/fusion/map"/>
145146
<arg name="use_intra_process" value="true"/>
146147
<arg name="use_multithread" value="true"/>
148+
<arg name="use_pointcloud_container" value="$(var use_pointcloud_container)"/>
147149
<arg name="pointcloud_container_name" value="$(var pointcloud_container_name)"/>
148150
<arg name="method" value="pointcloud_based_occupancy_grid_map"/>
149151
<arg name="fusion_config_file" value="$(var fusion_config_file)"/>

0 commit comments

Comments
 (0)