fix(tier4_camera_view_rviz_plugin): fix unusedFunction (#8639)

kobayu858 · web-flow · commit a64566ee7437 · 2024-08-27T15:34:21.000+09:00
* fix:unusedFunction

Signed-off-by: kobayu858 &lt;yutaro.kobayashi@tier4.jp&gt;

* fix:clang format

Signed-off-by: kobayu858 &lt;yutaro.kobayashi@tier4.jp&gt;

* fix:unusedFunction

Signed-off-by: kobayu858 &lt;yutaro.kobayashi@tier4.jp&gt;

---------

Signed-off-by: kobayu858 &lt;yutaro.kobayashi@tier4.jp&gt;
diff --git a/common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp b/common/tier4_camera_view_rviz_plugin/src/bird_eye_view_controller.cpp
@@ -99,6 +99,7 @@ void BirdEyeViewController::reset()
   y_property_->setFloat(0);
 }
 
+// cppcheck-suppress unusedFunction
 void BirdEyeViewController::handleMouseEvent(rviz_common::ViewportMouseEvent & event)
 {
   if (event.shift()) {
@@ -178,11 +179,13 @@ void BirdEyeViewController::update(float dt, float ros_dt)
   updateCamera();
 }
 
+// cppcheck-suppress unusedFunction
 void BirdEyeViewController::lookAt(const Ogre::Vector3 & point)
 {
   setPosition(point - target_scene_node_->getPosition());
 }
 
+// cppcheck-suppress unusedFunction
 void BirdEyeViewController::onTargetFrameChanged(
   const Ogre::Vector3 & old_reference_position,
   const Ogre::Quaternion & /*old_reference_orientation*/)
diff --git a/common/tier4_camera_view_rviz_plugin/src/third_person_view_controller.cpp b/common/tier4_camera_view_rviz_plugin/src/third_person_view_controller.cpp
@@ -226,6 +226,7 @@ void ThirdPersonViewController::updateCamera()
       distance_property_->getFloat() * CAMERA_OFFSET);
 }
 
+// cppcheck-suppress unusedFunction
 void ThirdPersonViewController::updateTargetSceneNode()
 {
   if (FramePositionTrackingViewController::getNewTransform()) {

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ void BirdEyeViewController::reset()`
`99`	`99`	`y_property_->setFloat(0);`
`100`	`100`	`}`
`101`	`101`
	`102`	`+// cppcheck-suppress unusedFunction`
`102`	`103`	`void BirdEyeViewController::handleMouseEvent(rviz_common::ViewportMouseEvent & event)`
`103`	`104`	`{`
`104`	`105`	`if (event.shift()) {`
`@@ -178,11 +179,13 @@ void BirdEyeViewController::update(float dt, float ros_dt)`
`178`	`179`	`updateCamera();`
`179`	`180`	`}`
`180`	`181`
	`182`	`+// cppcheck-suppress unusedFunction`
`181`	`183`	`void BirdEyeViewController::lookAt(const Ogre::Vector3 & point)`
`182`	`184`	`{`
`183`	`185`	`setPosition(point - target_scene_node_->getPosition());`
`184`	`186`	`}`
`185`	`187`
	`188`	`+// cppcheck-suppress unusedFunction`
`186`	`189`	`void BirdEyeViewController::onTargetFrameChanged(`
`187`	`190`	`const Ogre::Vector3 & old_reference_position,`
`188`	`191`	`const Ogre::Quaternion & /old_reference_orientation/)`
Original file line number	Diff line number	Diff line change
`@@ -226,6 +226,7 @@ void ThirdPersonViewController::updateCamera()`
`226`	`226`	`distance_property_->getFloat() * CAMERA_OFFSET);`
`227`	`227`	`}`
`228`	`228`
	`229`	`+// cppcheck-suppress unusedFunction`
`229`	`230`	`void ThirdPersonViewController::updateTargetSceneNode()`
`230`	`231`	`{`
`231`	`232`	`if (FramePositionTrackingViewController::getNewTransform()) {`