Skip to content

Commit a34b413

Browse files
Ahmed Ebrahimahmeddesokyebrahim
Ahmed Ebrahim
authored andcommitted
feat(remaining_dist_eta): removing functions usage from mission planner and default planner
Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai> feat(remaining_dist_eta): removing unneeded change in mission planner and default planner Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> feat(remaining_dist_eta): removing unneeded lines Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> feat(remaining_dist_eta): removing unneeded lines Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
1 parent 60ebabc commit a34b413

File tree

5 files changed

+0
-57
lines changed

5 files changed

+0
-57
lines changed

planning/mission_planner/include/mission_planner/mission_planner_plugin.hpp

-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ namespace mission_planner
3030
class PlannerPlugin
3131
{
3232
public:
33-
using Pose = geometry_msgs::msg::Pose;
3433
using RoutePoints = std::vector<geometry_msgs::msg::Pose>;
3534
using LaneletRoute = autoware_planning_msgs::msg::LaneletRoute;
3635
using HADMapBin = autoware_auto_mapping_msgs::msg::HADMapBin;
@@ -41,7 +40,6 @@ class PlannerPlugin
4140
virtual void initialize(rclcpp::Node * node, const HADMapBin::ConstSharedPtr msg) = 0;
4241
virtual bool ready() const = 0;
4342
virtual LaneletRoute plan(const RoutePoints & points) = 0;
44-
virtual void calculateRemainingDistance(const Pose & current_vehicle_pose, const geometry_msgs::msg::Vector3 & current_vehicle_velocity) = 0;
4543
virtual MarkerArray visualize(const LaneletRoute & route) const = 0;
4644
virtual void updateRoute(const LaneletRoute & route) = 0;
4745
virtual void clearRoute() = 0;

planning/mission_planner/src/lanelet2_plugins/default_planner.cpp

-38
Original file line numberDiff line numberDiff line change
@@ -158,41 +158,6 @@ void DefaultPlanner::initialize_common(rclcpp::Node * node)
158158
param_.consider_no_drivable_lanes = node_->declare_parameter<bool>("consider_no_drivable_lanes");
159159
param_.check_footprint_inside_lanes =
160160
node_->declare_parameter<bool>("check_footprint_inside_lanes");
161-
162-
}
163-
164-
void DefaultPlanner::calculateRemainingDistance(const Pose & current_vehicle_pose, const geometry_msgs::msg::Vector3 & current_vehicle_velocity)
165-
{
166-
if (is_route_planned) {
167-
const auto logger = node_->get_logger();
168-
double remaining_distance = route_handler_.getRemainingDistance(current_vehicle_pose, goal_pose_);
169-
170-
double current_veh_vel_mag = std::sqrt(current_vehicle_velocity.x * current_vehicle_velocity.x + current_vehicle_velocity.y + current_vehicle_velocity.y);
171-
RCLCPP_INFO_STREAM(logger, "current_vehicle_velocity.x = " << current_vehicle_velocity.x);
172-
RCLCPP_INFO_STREAM(logger, "current_vehicle_velocity.y = " << current_vehicle_velocity.y);
173-
RCLCPP_INFO_STREAM(logger, "current_veh_vel_mag = " << current_veh_vel_mag);
174-
175-
// double eta = remaining_distance / current_veh_vel_mag;
176-
route_handler::EstimatedTimeOfArrival eta = route_handler_.getEstimatedTimeOfArrival(remaining_distance, current_vehicle_velocity);
177-
//uint8_t seconds = route_handler_.getEstimatedTimeOfArrival(remaining_distance, current_vehicle_velocity).seconds;
178-
//const auto eta = route_handler_.getEsatimatedTimeOfArrival(remaining_distance, current_vehicle_velocity);
179-
180-
RCLCPP_INFO_STREAM(logger, "Remaining Distance = " << remaining_distance << " m");
181-
RCLCPP_INFO_STREAM(logger, "ETA = " << unsigned(eta.hours) << "H : " << unsigned(eta.minutes) << "M : " << unsigned(eta.seconds) << "S");
182-
// double remaining_time = remaining_distance / current_veh_vel_mag;
183-
// RCLCPP_INFO_STREAM(logger, "remaining_time = " << remaining_time);
184-
// double hours = static_cast<uint8_t>(remaining_time / 3600);
185-
// RCLCPP_INFO_STREAM(logger, "hours = " << hours);
186-
// remaining_time = std::fmod(remaining_time, 3600);
187-
// RCLCPP_INFO_STREAM(logger, "remaining_time = " << remaining_time);
188-
// double minutes = static_cast<int>(remaining_time / 60);
189-
// RCLCPP_INFO_STREAM(logger, "minutes = " << minutes);
190-
// double seconds = static_cast<int>(fmod(remaining_time, 60));
191-
// RCLCPP_INFO_STREAM(logger, "seconds = " << seconds);
192-
// RCLCPP_INFO_STREAM(logger, "hours = " << eta.hours);
193-
// RCLCPP_INFO_STREAM(logger, "minutes = " << eta.minutes);
194-
// RCLCPP_INFO_STREAM(logger, "seconds = " << eta.seconds);
195-
}
196161
}
197162

198163
void DefaultPlanner::initialize(rclcpp::Node * node)
@@ -475,9 +440,6 @@ PlannerPlugin::LaneletRoute DefaultPlanner::plan(const RoutePoints & points)
475440
const auto refined_goal = refine_goal_height(goal_pose, route_sections);
476441
RCLCPP_DEBUG(logger, "Goal Pose Z : %lf", refined_goal.position.z);
477442

478-
is_route_planned = true;
479-
goal_pose_ = refined_goal;
480-
481443
// The header is assigned by mission planner.
482444
route_msg.start_pose = points.front();
483445
route_msg.goal_pose = refined_goal;

planning/mission_planner/src/lanelet2_plugins/default_planner.hpp

-4
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ class DefaultPlanner : public mission_planner::PlannerPlugin
5151
MarkerArray visualize(const LaneletRoute & route) const override;
5252
MarkerArray visualize_debug_footprint(tier4_autoware_utils::LinearRing2d goal_footprint_) const;
5353
vehicle_info_util::VehicleInfo vehicle_info_;
54-
void calculateRemainingDistance(const Pose & current_vehicle_pose, const geometry_msgs::msg::Vector3 & current_vehicle_velocity) override;
5554

5655
private:
5756
using RouteSections = std::vector<autoware_planning_msgs::msg::LaneletSegment>;
@@ -63,8 +62,6 @@ class DefaultPlanner : public mission_planner::PlannerPlugin
6362
lanelet::ConstLanelets road_lanelets_;
6463
lanelet::ConstLanelets shoulder_lanelets_;
6564
route_handler::RouteHandler route_handler_;
66-
bool is_route_planned{false};
67-
Pose goal_pose_;
6865

6966
DefaultPlannerParameters param_;
7067

@@ -74,7 +71,6 @@ class DefaultPlanner : public mission_planner::PlannerPlugin
7471

7572
void initialize_common(rclcpp::Node * node);
7673
void map_callback(const HADMapBin::ConstSharedPtr msg);
77-
void calculateRemainingDistance(Pose & current_vehicle_pose);
7874

7975
/**
8076
* @brief check if the goal_footprint is within the combined lanelet of route_lanelets plus the

planning/mission_planner/src/mission_planner/mission_planner.cpp

-9
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,9 @@ MissionPlanner::MissionPlanner(const rclcpp::NodeOptions & options)
8484
const auto period = rclcpp::Rate(10).period();
8585
data_check_timer_ = create_wall_timer(period, [this] { check_initialization(); });
8686

87-
remaining_distance_timer_ = this->create_wall_timer(std::chrono::milliseconds(500), std::bind(&MissionPlanner::remaining_distance_timer_callback_, this));
88-
8987
logger_configure_ = std::make_unique<tier4_autoware_utils::LoggerLevelConfigure>(this);
9088
}
9189

92-
void MissionPlanner::remaining_distance_timer_callback_()
93-
{
94-
//planner_->calculateRemainingDistance(current_vehicle_pose, current_vehicle_velocity);
95-
}
96-
9790
void MissionPlanner::check_initialization()
9891
{
9992
auto logger = get_logger();
@@ -120,8 +113,6 @@ void MissionPlanner::check_initialization()
120113
void MissionPlanner::on_odometry(const Odometry::ConstSharedPtr msg)
121114
{
122115
odometry_ = msg;
123-
current_vehicle_pose = odometry_->pose.pose;
124-
current_vehicle_velocity = odometry_->twist.twist.linear;
125116

126117
// NOTE: Do not check in the other states as goal may change.
127118
if (state_.state == RouteState::SET) {

planning/mission_planner/src/mission_planner/mission_planner.hpp

-4
Original file line numberDiff line numberDiff line change
@@ -124,16 +124,12 @@ class MissionPlanner : public rclcpp::Node
124124

125125
rclcpp::TimerBase::SharedPtr data_check_timer_;
126126
void check_initialization();
127-
rclcpp::TimerBase::SharedPtr remaining_distance_timer_;
128-
void remaining_distance_timer_callback_();
129127

130128
double reroute_time_threshold_;
131129
double minimum_reroute_length_;
132130
bool check_reroute_safety(const LaneletRoute & original_route, const LaneletRoute & target_route);
133131

134132
std::unique_ptr<tier4_autoware_utils::LoggerLevelConfigure> logger_configure_;
135-
Pose current_vehicle_pose;
136-
geometry_msgs::msg::Vector3 current_vehicle_velocity;
137133
};
138134

139135
} // namespace mission_planner

0 commit comments

Comments
 (0)