Skip to content

Commit 84bede5

Browse files
authored
refactor(autoware_behavior_velocity_speed_bump_module): prefix package and namespace with autoware (#7467)
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
1 parent ef3cef1 commit 84bede5

File tree

21 files changed

+10
-17
lines changed

21 files changed

+10
-17
lines changed

.github/CODEOWNERS

+1-1
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,12 @@ planning/behavior_velocity_planner/autoware_behavior_velocity_occlusion_spot_mod
185185
planning/behavior_velocity_planner/autoware_behavior_velocity_planner/** kosuke.takeuchi@tier4.jp kyoichi.sugahara@tier4.jp makoto.kurihara@tier4.jp mamoru.sobue@tier4.jp maxime.clement@tier4.jp satoshi.ota@tier4.jp shumpei.wakabayashi@tier4.jp taiki.tanaka@tier4.jp takayuki.murooka@tier4.jp tomohito.ando@tier4.jp tomoya.kimura@tier4.jp
186186
planning/behavior_velocity_planner/autoware_behavior_velocity_planner_common/** fumiya.watanabe@tier4.jp isamu.takagi@tier4.jp mamoru.sobue@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
187187
planning/behavior_velocity_planner/autoware_behavior_velocity_run_out_module/** kosuke.takeuchi@tier4.jp makoto.kurihara@tier4.jp shumpei.wakabayashi@tier4.jp takayuki.murooka@tier4.jp tomohito.ando@tier4.jp tomoya.kimura@tier4.jp
188+
planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/** mdogru@leodrive.ai shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
188189
planning/behavior_velocity_planner/autoware_behavior_velocity_stop_line_module/** fumiya.watanabe@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp zhe.shen@tier4.jp
189190
planning/behavior_velocity_planner/autoware_behavior_velocity_template_module/** daniel.sanchez@tier4.jp
190191
planning/behavior_velocity_planner/autoware_behavior_velocity_traffic_light_module/** mamoru.sobue@tier4.jp satoshi.ota@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
191192
planning/behavior_velocity_planner/autoware_behavior_velocity_virtual_traffic_light_module/** kosuke.takeuchi@tier4.jp shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
192193
planning/behavior_velocity_planner/autoware_behavior_velocity_walkway_module/** satoshi.ota@tier4.jp shumpei.wakabayashi@tier4.jp takayuki.murooka@tier4.jp tomoya.kimura@tier4.jp
193-
planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/** mdogru@leodrive.ai shumpei.wakabayashi@tier4.jp tomoya.kimura@tier4.jp
194194
planning/motion_velocity_planner/autoware_motion_velocity_dynamic_obstacle_stop_module/** mamoru.sobue@tier4.jp maxime.clement@tier4.jp
195195
planning/motion_velocity_planner/autoware_motion_velocity_obstacle_velocity_limiter_module/** maxime.clement@tier4.jp
196196
planning/motion_velocity_planner/autoware_motion_velocity_out_of_lane_module/** maxime.clement@tier4.jp shumpei.wakabayashi@tier4.jp takayuki.murooka@tier4.jp tomoya.kimura@tier4.jp

planning/.pages

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ nav:
2929
- 'No Stopping Area': planning/behavior_velocity_planner/autoware_behavior_velocity_no_stopping_area_module
3030
- 'Occlusion Spot': planning/behavior_velocity_planner/autoware_behavior_velocity_occlusion_spot_module
3131
- 'Run Out': planning/behavior_velocity_planner/autoware_behavior_velocity_run_out_module
32-
- 'Speed Bump': planning/behavior_velocity_planner/behavior_velocity_speed_bump_module
32+
- 'Speed Bump': planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module
3333
- 'Stop Line': planning/behavior_velocity_planner/autoware_behavior_velocity_stop_line_module
3434
- 'Traffic Light': planning/behavior_velocity_planner/autoware_behavior_velocity_traffic_light_module
3535
- 'Virtual Traffic Light': planning/behavior_velocity_planner/autoware_behavior_velocity_virtual_traffic_light_module

planning/behavior_velocity_planner/autoware_behavior_velocity_planner/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ It loads modules as plugins. Please refer to the links listed below for detail o
1919
- [Occlusion Spot](../autoware_behavior_velocity_occlusion_spot_module/README.md)
2020
- [No Stopping Area](../autoware_behavior_velocity_no_stopping_area_module/README.md)
2121
- [Run Out](../autoware_behavior_velocity_run_out_module/README.md)
22-
- [Speed Bump](../behavior_velocity_speed_bump_module/README.md)
22+
- [Speed Bump](../autoware_behavior_velocity_speed_bump_module/README.md)
2323

2424
When each module plans velocity, it considers based on `base_link`(center of rear-wheel axis) pose.
2525
So for example, in order to stop at a stop line with the vehicles' front on the stop line, it calculates `base_link` position from the distance between `base_link` to front and modifies path velocity from the `base_link` position.

planning/behavior_velocity_planner/autoware_behavior_velocity_planner/package.xml

+1-2
Original file line numberDiff line numberDiff line change
@@ -66,20 +66,19 @@
6666
<test_depend>ament_cmake_ros</test_depend>
6767
<test_depend>ament_lint_auto</test_depend>
6868
<test_depend>autoware_behavior_velocity_blind_spot_module</test_depend>
69-
<test_depend>autoware_behavior_velocity_blind_spot_module</test_depend>
7069
<test_depend>autoware_behavior_velocity_crosswalk_module</test_depend>
7170
<test_depend>autoware_behavior_velocity_detection_area_module</test_depend>
7271
<test_depend>autoware_behavior_velocity_intersection_module</test_depend>
7372
<test_depend>autoware_behavior_velocity_no_drivable_lane_module</test_depend>
7473
<test_depend>autoware_behavior_velocity_no_stopping_area_module</test_depend>
7574
<test_depend>autoware_behavior_velocity_occlusion_spot_module</test_depend>
7675
<test_depend>autoware_behavior_velocity_run_out_module</test_depend>
76+
<test_depend>autoware_behavior_velocity_speed_bump_module</test_depend>
7777
<test_depend>autoware_behavior_velocity_stop_line_module</test_depend>
7878
<test_depend>autoware_behavior_velocity_traffic_light_module</test_depend>
7979
<test_depend>autoware_behavior_velocity_virtual_traffic_light_module</test_depend>
8080
<test_depend>autoware_behavior_velocity_walkway_module</test_depend>
8181
<test_depend>autoware_lint_common</test_depend>
82-
<test_depend>behavior_velocity_speed_bump_module</test_depend>
8382
<!--<test_depend>autoware_behavior_velocity_template_module</test_depend>-->
8483

8584
<member_of_group>rosidl_interface_packages</member_of_group>

planning/behavior_velocity_planner/autoware_behavior_velocity_planner/test/src/test_node_interface.cpp

+1-7
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,6 @@ std::shared_ptr<BehaviorVelocityPlannerNode> generateNode()
5555
ament_index_cpp::get_package_share_directory("autoware_velocity_smoother");
5656

5757
// TODO(esteve): delete when all the modules are migrated to autoware_behavior_velocity_*
58-
const auto get_behavior_velocity_module_config_no_prefix = [](const std::string & module) {
59-
const auto package_name = "behavior_velocity_" + module + "_module";
60-
const auto package_path = ament_index_cpp::get_package_share_directory(package_name);
61-
return package_path + "/config/" + module + ".param.yaml";
62-
};
63-
6458
const auto get_behavior_velocity_module_config = [](const std::string & module) {
6559
const auto package_name = "autoware_behavior_velocity_" + module + "_module";
6660
const auto package_path = ament_index_cpp::get_package_share_directory(package_name);
@@ -103,7 +97,7 @@ std::shared_ptr<BehaviorVelocityPlannerNode> generateNode()
10397
get_behavior_velocity_module_config("no_stopping_area"),
10498
get_behavior_velocity_module_config("occlusion_spot"),
10599
get_behavior_velocity_module_config("run_out"),
106-
get_behavior_velocity_module_config_no_prefix("speed_bump"),
100+
get_behavior_velocity_module_config("speed_bump"),
107101
get_behavior_velocity_module_config("stop_line"),
108102
get_behavior_velocity_module_config("traffic_light"),
109103
get_behavior_velocity_module_config("virtual_traffic_light"),

planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/CMakeLists.txt planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
cmake_minimum_required(VERSION 3.14)
2-
project(behavior_velocity_speed_bump_module)
2+
project(autoware_behavior_velocity_speed_bump_module)
33

44
find_package(autoware_cmake REQUIRED)
55
autoware_package()

planning/behavior_velocity_planner/behavior_velocity_speed_bump_module/package.xml planning/behavior_velocity_planner/autoware_behavior_velocity_speed_bump_module/package.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0"?>
22
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
33
<package format="3">
4-
<name>behavior_velocity_speed_bump_module</name>
4+
<name>autoware_behavior_velocity_speed_bump_module</name>
55
<version>0.1.0</version>
6-
<description>The behavior_velocity_speed_bump_module package</description>
6+
<description>The autoware_behavior_velocity_speed_bump_module package</description>
77

88
<maintainer email="tomoya.kimura@tier4.jp">Tomoya Kimura</maintainer>
99
<maintainer email="shumpei.wakabayashi@tier4.jp">Shumpei Wakabayashi</maintainer>
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<library path="behavior_velocity_speed_bump_module">
1+
<library path="autoware_behavior_velocity_speed_bump_module">
22
<class type="autoware::behavior_velocity_planner::SpeedBumpModulePlugin" base_class_type="autoware::behavior_velocity_planner::PluginInterface"/>
33
</library>

planning/behavior_velocity_planner/autoware_behavior_velocity_template_module/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## Template
22

3-
A template for behavior velocity modules based on the behavior_velocity_speed_bump_module.
3+
A template for behavior velocity modules based on the autoware_behavior_velocity_speed_bump_module.
44

55
# Autoware Behavior Velocity Module Template
66

0 commit comments

Comments
 (0)