Skip to content

Commit 2970485

Browse files
authored
fix(raw_vehicle_cmd_converter): inconsitent sign of braking command (#1945)
fix inconsitent sign of braking command Signed-off-by: Grzegorz Głowacki <Grzegorz Głowacki gglowacki@autonomous-systems.pl> Signed-off-by: Grzegorz Głowacki <Grzegorz Głowacki gglowacki@autonomous-systems.pl>
1 parent 1b23f84 commit 2970485

File tree

1 file changed

+6
-4
lines changed
  • vehicle/raw_vehicle_cmd_converter/src

1 file changed

+6
-4
lines changed

vehicle/raw_vehicle_cmd_converter/src/node.cpp

+6-4
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,9 @@ void RawVehicleCommandConverterNode::publishActuationCmd()
102102
}
103103
if (!current_twist_ptr_ || !control_cmd_ptr_ || !current_steer_ptr_) {
104104
RCLCPP_WARN_EXPRESSION(
105-
get_logger(), is_debugging_, "some of twist/control_cmd/steer pointer is null");
105+
get_logger(), is_debugging_, "some pointers are null: %s, %s, %s",
106+
!current_twist_ptr_ ? "twist" : "", !control_cmd_ptr_ ? "cmd" : "",
107+
!current_steer_ptr_ ? "steer" : "");
106108
return;
107109
}
108110
double desired_accel_cmd = 0.0;
@@ -124,9 +126,9 @@ void RawVehicleCommandConverterNode::publishActuationCmd()
124126
if (accel_cmd_is_zero) {
125127
desired_brake_cmd = calculateBrakeMap(vel, acc);
126128
}
127-
} else {
128-
// if conversion is disabled use acceleration as brake cmd
129-
desired_brake_cmd = (acc < 0) ? acc : 0;
129+
} else if (acc < 0) {
130+
// if conversion is disabled use negative acceleration as brake cmd
131+
desired_brake_cmd = -acc;
130132
}
131133
if (convert_steer_cmd_) {
132134
desired_steer_cmd = calculateSteer(vel, steer, steer_rate);

0 commit comments

Comments
 (0)