Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lanelet2_map_validator): check local coordinates declaration #194

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Jan 14, 2025

Description

This PR adds a validator mapping.intersection.local_coordinates_declaration that checks whether all points have local_x & local_y or all points don't have local_x and local_y.

In short, this PR adds the following implementation.

  • New validator mapping.lane.local_coordinates_declaration.
  • A test code for mapping.lane.local_coordinates_declaration.
  • A document for mapping.lane.local_coordinates_declaration.

How was this PR tested?

  1. Confirmed that colcon test --packages-select autoware_lanelet2_map_validator --event-handlers console_cohesion+ passes.
  2. Confirmed that the following command shows no mistakes against several lanelet2 maps I have.
ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator -p mgrs -m <PATH_TO_sample_map.osm> -i <PATH_TO_autoware_requirement_set.json> -o ./

Notes for reviewers

This validation item is NOT included in the autoware vector map requirements, so it's not included to autoware_requirement_set.json.

Effects on system behavior

None.

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@YamatoAndo
Copy link
Contributor

### Description

This PR adds a validator mapping.intersection.local_coordinates_declaration that checks whether all points have local_x & local_y or all points don't have local_x and local_y.

In short, this PR adds the following implementation.

New validator mapping.intersection.local_coordinates_declaration.
A test code for mapping.intersection.local_coordinates_declaration.
A document for mapping.intersection.local_coordinates_declaration.

mapping.intersection.local_coordinates_declaration -> mapping.lane.local_coordinates_declaration

@TaikiYamada4 TaikiYamada4 merged commit c12383c into autowarefoundation:main Jan 27, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants