chore(traffic_light_multi_camera_fusion): read parameters from yaml file #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
TomohitoAndo
requested review from
miursh,
YoshiRi,
kminoda and
technolojin
as code owners
TomohitoAndo
changed the title
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
MasatoSaeki
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
I approve this PR by autowarefoundation/autoware.universe#10144 (review)
|
@YoshiRi @technolojin |
technolojin
approved these changes
Feb 19, 2025
TomohitoAndo
added a commit
to tier4/autoware_launch
that referenced
this pull request
Feb 19, 2025
…ile (autowarefoundation#1331) * chore(traffic_light_multi_camera_fusion): read parameters from yaml file Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * style(pre-commit): autofix * remove camera namespace parameter from config file Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> --------- Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR for universe: autowarefoundation/autoware.universe#10144
Currently, the parameters for
traffic_light_multi_camera_fusionare hardcoded in the launch file, preventing modifications from the launch file.To resolve this issue, I modified it to read parameters from a YAML file in
autoware_launch.How was this PR tested?
Please see autowarefoundation/autoware.universe#10144
Notes for reviewers
The default values in the parameter file is the same as the one in
autoware.universe.https://github.com/TomohitoAndo/autoware.universe/blob/614ac8e762e644aec1b1d2b74b87755c27f1a453/perception/autoware_traffic_light_multi_camera_fusion/config/traffic_light_multi_camera_fusion.param.yaml
Effects on system behavior
None.