Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_map_loader): port autoware_map_loader from Autoware Universe to Core #326

Merged

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Mar 27, 2025

Description

This ports the autoware_map_loader package from Autoware Universe with the following fix:

  • remove CHANGELOG.rst
  • reset version in package.xml
  • replace autoware_component_interface_specs_universe with autwoare_component_interface_specs

This must be merged with: autowarefoundation/autoware_universe#10356

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
…G.rst

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r requested a review from YamatoAndo March 27, 2025 07:45
Copy link

github-actions bot commented Mar 27, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r requested review from a team and Motsu-san March 27, 2025 07:45
@mitsudome-r mitsudome-r changed the title feat: port autoware_map_loader and autoware_laneelt2_map_visualizer from Autoware Universe to Core feat(autoware_map_loader): port autoware_map_loader from Autoware Universe to Core Mar 27, 2025
…ation for Core

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 37.46313% with 212 lines in your changes missing coverage. Please review.

Project coverage is 32.33%. Comparing base (4cb18f5) to head (d275b4e).
Report is 118 commits behind head on main.

Files with missing lines Patch % Lines
...c/lanelet2_map_loader/lanelet2_map_loader_node.cpp 13.69% 63 Missing ⚠️
...intcloud_map_loader/pointcloud_map_loader_node.cpp 1.75% 56 Missing ⚠️
...intcloud_map_loader/selected_map_loader_module.cpp 0.00% 50 Missing ⚠️
...tcloud_map_loader/pointcloud_map_loader_module.cpp 37.50% 18 Missing and 7 partials ⚠️
...loud_map_loader/differential_map_loader_module.cpp 80.00% 4 Missing and 4 partials ⚠️
...c/lanelet2_map_loader/lanelet2_local_projector.hpp 0.00% 6 Missing ⚠️
...ointcloud_map_loader/partial_map_loader_module.cpp 90.32% 1 Missing and 2 partials ⚠️
...are_map_loader/src/pointcloud_map_loader/utils.cpp 97.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #326       +/-   ##
===========================================
- Coverage   78.75%   32.33%   -46.42%     
===========================================
  Files          11       13        +2     
  Lines         193      402      +209     
  Branches       73      216      +143     
===========================================
- Hits          152      130       -22     
- Misses         11      258      +247     
+ Partials       30       14       -16     
Flag Coverage Δ
differential 32.33% <37.46%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested only the cosmetic fixes. So LGTM

@mitsudome-r mitsudome-r merged commit 5887654 into autowarefoundation:main Mar 27, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Development

Successfully merging this pull request may close these issues.

3 participants