Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_path_generator): remove redundant move #318

Merged

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 25, 2025

Description

The compiler on Ubuntu Noble warns about a redundant move, and -Werror causes the build to fail. This PR removes that move.

/workspaces/ros2/src/autoware/core/autoware.core/planning/autoware_path_generator/src/utils.cpp: In function ‘std::optional<std::vector<lanelet::ConstLanelet> > autoware::path_generator::utils::get_lanelets_within_route(const lanelet::ConstLanelet&, const autoware::path_generator::PlannerData&, const geometry_msgs::msg::Pose&, double, double)’:
/workspaces/ros2/src/autoware/core/autoware.core/planning/autoware_path_generator/src/utils.cpp:96:64: error: redundant move in initialization [-Werror=redundant-move]
   96 |   lanelet::ConstLanelets lanelets(std::move(*backward_lanelets));
      |                                                                ^
/workspaces/ros2/src/autoware/core/autoware.core/planning/autoware_path_generator/src/utils.cpp:96:64: note: remove ‘std::move’ call

Related links

Parent Issue:

  • Link

How was this PR tested?

Ubuntu Noble ROS Rolling with ament/ament_cmake#571

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@wep21 wep21 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.04%. Comparing base (4cb18f5) to head (1cbe382).
Report is 109 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #318       +/-   ##
===========================================
- Coverage   78.75%   18.04%   -60.71%     
===========================================
  Files          11       94       +83     
  Lines         193     4233     +4040     
  Branches       73      880      +807     
===========================================
+ Hits          152      764      +612     
- Misses         11     3371     +3360     
- Partials       30       98       +68     
Flag Coverage Δ
differential 18.04% <100.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wep21 wep21 self-requested a review March 26, 2025 04:54
@kosuke55 kosuke55 changed the title fix: remove redundant move fix(autoware_path_generator): remove redundant move Mar 26, 2025
@kosuke55
Copy link
Contributor

kosuke55 commented Mar 26, 2025

thanks!
checked build Finished <<< autoware_path_generator [32.7s]

@kosuke55 kosuke55 merged commit be38b21 into autowarefoundation:main Mar 26, 2025
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants