fix(autoware_gnss_poser): depend on geographiclib through its Find module #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
requested review from
anhnv3991,
KYabuuchi,
liuXinGangChina,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4,
YamatoAndo and
a team
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
liuXinGangChina
added
run:build-and-test-differential
|
hi @sloretz Thanks for improve the cmakelists file， Let me check it in autoware offcial docker 心刚 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
- Coverage 78.75% 0.00% -78.76%
==========================================
Files 11 4 -7
Lines 193 272 +79
Branches 73 20 -53
==========================================
- Hits 152 0 -152
- Misses 11 272 +261
+ Partials 30 0 -30
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sloretz
changed the title
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
liuXinGangChina
force-pushed
the
sloretz_fix_finding_geographiclib
branch
from
83e21e8 to
7c138fc
Compare
liuXinGangChina
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Thanks for your contribution @sloretz
I have test your pr with AWF official devel docker image， and everything goes well .
Best regrads
心刚
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes building the
autoware_gnss_poserpackage on Ubuntu Noble. I replaced all the find package stuff with using the find module provided by Geographic lib. The call totarget_link_libraries()wasn't needed becauseament_auto_add_library()automatically depends on it because the rosdep key name matches the find module name: geographiclibRelated links
Parent Issue:
How was this PR tested?
I'm building on Ubuntu Noble using ament/ament_cmake#571
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.